fix(ci): correct Bencher reporting and benchmark failures - #176
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Self-hosted validation passed: run 34700974127. Both the original failure and the validation ran on For the previously alerted DynamicThreadPool / FAIR_SHARE / no queue scenario:
The slowdown did not reproduce in this execution with the same runner and runtime. This is evidence of run-to-run variability, not proof of a performance fix or identification of the external cause. The PR changes reporting/error handling, not pool scheduling, benchmark workloads, or alert thresholds. The new testbed is required for the ms-to-ns reporting migration, not to dismiss the old alert. Historical reports remain available. |
2e4547f to
155fad3
Compare
|
Updated as requested: the commit no longer contains |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 455cc2a474
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| bmfResults[task.name] = { | ||
| latency: { | ||
| // Tinybench reports milliseconds; Bencher latency uses nanoseconds. | ||
| value: task.result.latency.mean * 1e6, |
There was a problem hiding this comment.
Reset incompatible latency history before scaling samples
When this runs against the existing master/self-hosted Bencher history, all prior latency samples were published directly in Tinybench milliseconds, while this line makes only new samples one million times larger. The production path in .github/workflows/internal-benchmark.yml continues publishing to that same branch, testbed, and measure and uses --err, so valid runs will be classified as enormous regressions and fail until the incompatible history ages out. Migrate/reset the historical latency data or publish the corrected series under a fresh testbed before enabling this conversion.
Useful? React with 👍 / 👎.
|



PR Checklist
Does this PR introduce a breaking change?
RCA
Changes
self-hostedtestbed. Historical latency values are milliseconds labeled as nanoseconds; without migrating that history, corrected nanosecond reports will trigger artificial latency regressions. This PR does not migrate or delete stored data. Throughput units are unchanged.latest; delay npm updates in Deno manifests by one day using strict Renovate age filtering.Verification
self-hostedtestbed in dry-run, without altering production results.