Repository navigation
Conversation
Route successful history output to stdout while retaining diagnostics and exit behavior. Cover the real CLI output streams with offline child-process regressions.
Contributor
Author
|
Hi @portdeveloper, just following up on this PR. CI is green on Linux and Windows. Could you take a look when you have a chance? Happy to address any feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Closes #129.
Send successful
/historyoutput, including the empty-history result, to stdout so a scripted read can be redirected. Preserve the existing interactive text, diagnostics and exit behavior.How I tested it
npm run buildsucceedsnpm run smokeprintsSMOKE_OKnpm test: 635 passed. The six new child-process tests run the real CLI startup, slash dispatch and exit path with fixed offline wallet/model boundaries and separate stdout/stderr capture. The three history-output regressions fail on the unchanged base; the three error/usage/exit controls pass there.Independent checks cover exact result text, mixed reads, CRLF input, sticky failure status and actual interactive PTY input with both redirected and terminal stdout. No live model or wallet was used. The application smoke stops at missing
WDK_SEED, before wallet or model initialization, soSMOKE_OKis unverified.A temporary combination with #131 (
78fa77c) also builds and passes all 640 tests, including the history stream regressions and gas-mode startup checks.Model / platform tested on: fixed wallet/model fixtures; Linux x64, Node 22.22.2. Windows runtime verification is left to the configured CI matrix.
Scope check
Conventions
npm(not pnpm/yarn) and did not add a globalsodium-nativeoverride..env, seeds, keys, or model weights.