Repository navigation
fix(py): widen create_model field spec annotations for pyright - #326
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #325, which pulled in the entire stacked
ggsql-caching-reader+ maps-capability history because its head branch (feat/maps-capability-py) is shared with #323. This PR contains just the pyright fix, based directly onmain.Summary
handoff_result_model()inpkg-py/src/querychat/_handoff_prompt.pybuilds pydantic field specs as inferred tuples. Newer pydantic stubs (withTypeForm) reject those inferred types as arguments tocreate_model()(reportCallIssue), which surfaced as a pyright failure on the Python 3.10 CI job. Adding explicittuple[Any, Any]annotations widens the inferred types so the call type-checks.The identical change is also present in #323 and #324; this PR lets it land on
mainimmediately without waiting for the stacked feature work. The ruff cleanups that were also in #325 (de7d660d) only touch code from the stacked branches and remain with #323.Verification
uv run pyrightreports no errors forpkg-py/src/querychat/_handoff_prompt.pywith this change, anduv run ruff checkpasses.