Repository navigation
Conversation
A previous commit on this branch made viz_dep() use a dep_version() helper whose definition was never committed, so importing querychat._viz_tools raised ImportError and the Python CI job on #323 failed at collection time. Restore the direct __version__ usage.
viz.css forced background-color: var(--bs-light) on .prism-code-editor inside .querychat-query-section, so in dark mode the github-dark syntax theme's light text rendered on a forced light background (light-on-light, illegible). Drop the override so the active prism theme's --editor__bg applies (github-light #fff / github-dark #0d1117); shiny's code editor already switches themes with data-bs-theme. Affects both the viz footer's "Show Query" editor and the data drawer's SQL editor, which share the .querychat-query-section wrapper.
The previous commit edited the generated pkg-py copy of viz.css directly; the source of truth is js/src/viz.css, which also feeds pkg-r/inst/htmldep/viz.css.
cpsievert
marked this pull request as ready for review
October 15, 2026 15:23
Contributor
Author
|
Superseded: the _viz_tools import fix went directly onto feat/maps-capability-py (c9b3967), and the dark-mode CSS fix will be re-proposed as a new PR based on main, since the bug exists there too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes from the 2026-10-14 maps smoke test (
_dev/maps-spatial-findings-2026-10-14.md):Unbreak
querychat._viz_toolsimport on this branch. A previous commit onfeat/maps-capability-pymadeviz_dep()use adep_version()helper whose definition was never committed, so importingquerychat._viz_toolsraisesImportErrorand the Python CI job on feat(py): opt-in "maps" capability for visualizations #323 fails at collection time. This restores the direct__version__usage.Light-on-light SQL in dark mode (rough edge fix: No longer need to manually calls
session$ns()with shinychat #10).viz.cssforcedbackground-color: var(--bs-light)on.prism-code-editorinside.querychat-query-section, so in dark mode the github-dark syntax theme's light text rendered on a forced light background — illegible. The override is removed so the active prism theme's--editor__bgapplies (github-light#fff/ github-dark#0d1117); shiny's code editor already live-switches themes withdata-bs-theme. This affected both the viz footer's "Show Query" editor and the data drawer's SQL editor, which share the.querychat-query-sectionwrapper.Verification
ruff check,pyright,pytest(1018 passed) all green.viz.css: dark mode → editor bgrgb(13, 17, 23)withrgb(230, 237, 243)text; light mode →rgb(255, 255, 255)withrgb(36, 41, 46)text; live switching viainput_dark_modeworks.