expose pending indicator styling - #363
Open
simonpcouch wants to merge 2 commits into
Open
Conversation
Collaborator
|
I would be open to adopting Also, before we take any action here, I'll let @gadenbuie chime in with thoughts since he was here most recently |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to posit-dev/commons#144. This aims to give commons an entry point to overwrite the circular
...pending indicator with a different UI element.Exposing as CSS hooks rather than an
pending_indicatorHTML argument so that commons could implement its indicator entirely viacommons_theme().Adopting in commons (PR headed there shortly) looks like:
working-pending.mov