Skip to content

maintenance but nothing new - #87

Merged
MoOx merged 2 commits into
mainfrom
maintenance
Oct 9, 2026
Merged

MoOx merged 2 commits into
mainfrom
maintenance

Conversation

@MoOx

@MoOx MoOx commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI balanced review requested due to automatic review settings September 30, 2026 07:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The test harness can hide failures, Node.js 18 is untested, and several output and documentation correctness issues remain.

Review effort: Balanced
Findings: 3 Medium severity · 1 Low severity

Open (4)
What changed in this PR

Modernizes project maintenance, testing, and documentation without changing the core API.

Changes:

  • Migrates from pnpm, Tape, and ESLint to npm, node:test, oxlint, and oxfmt.
  • Reorganizes automated tests and replaces the visual fixture with a standalone script.
  • Refreshes package metadata, CI, documentation, and Node.js support.
File Description
.editorconfig Removes legacy editor settings.
.eslintignore Removes ESLint exclusions.
.eslintrc Removes ESLint configuration.
.gitattributes Enforces LF normalization.
.github/​workflows/​test.yml Migrates CI to npm and a platform matrix.
.node-version Selects Node.js 24.
CHANGELOG.md Documents maintenance changes.
README.md Refreshes badges, examples, and metadata.
index.js Applies formatting changes.
lib/​formatter.js Reformats formatter implementation.
lib/​formatter.test.js Migrates formatter tests to node:test.
lib/​reporter.js Reformats reporter implementation.
lib/​reporter.test.js Migrates reporter tests to node:test.
lib/​util.js Reformats utility code.
package-lock.json Adds npm dependency lockfile.
package.json Updates tooling, scripts, metadata, and engines.
pnpm-lock.yaml Removes pnpm lockfile.
scripts/​visual.js Adds standalone visual verification script.
test/​fixtures/​forVisual.css Removes obsolete visual fixture.
test/​fixtures/​less-bar.less Removes obsolete Less fixture.
test/​fixtures/​less-foo.less Removes obsolete Less fixture.
test/​formatter.js Removes Tape formatter tests.
test/​index.js Removes legacy test entry point.
test/​lessIntegration.js Removes Less integration script.
test/​reporter.js Removes Tape reporter tests.
test/​visual.js Removes legacy visual script.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/test.yml
Comment thread lib/reporter.js Outdated
Comment thread lib/reporter.test.js
Comment thread README.md Outdated
- Pass the counts to the pluralization helper so the summary reads
  "1 error" instead of "1 errors".
- Let unexpected reporter exceptions fail the tests, and opt into
  capturing them only where an error is expected.
- Document that errors are logged by default and always throw.
@MoOx
MoOx merged commit 812b44e into main Oct 9, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants