simplify deps & dev deps + node 22#193
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to simplify the development toolchain by removing Mocha/Chai/ESLint, migrating tests to Node’s built-in node:test runner, and switching linting to oxlint.
Changes:
- Replace Mocha/Chai-based test setup with
node:test+node:assert(with a small compatibility shim). - Replace ESLint with
oxlint, and remove ESLint config files. - Minor refactors/cleanups in tests and URL/path handling (regex simplifications,
startsWith,endsWith, slash normalization).
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
test/type/inline.js |
Updates assertions and simplifies a custom filter function. |
test/type/copy.js |
Cleans up regex/string escaping for URL path expectations. |
test/setup.js |
Migrates test harness from Chai/Mocha globals to node:test + node:assert. |
test/.eslintrc.js |
Removes test-specific ESLint config. |
src/lib/paths.js |
Small simplifications in path normalization and URL checks. |
package.json |
Drops mocha/chai/eslint, adds oxlint, updates test/lint scripts, bumps postcss-import. |
package-lock.json |
Updates lockfile to reflect new dev dependency set. |
.eslintrc.js |
Removes root ESLint configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes, but node <= 20 are at EOL.