Support custom key combinations in mobile terminal shortcuts - #310
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #308: terminal applications and user-defined keybindings can require combinations missing from the built-in mobile shortcut presets.
Users can choose Preset or Custom keyboard for each panel or side slot. The US QWERTY picker supports multiple Ctrl, Alt, and Shift modifiers with one main key, shows the selected combination, and updates number/symbol keycaps with Shift. Symbol keys are directly visible in two keyboard rows; navigation keys and F1-F12 appear in separate groups under More keys, with F1-F12 in three consecutive rows. Existing presets, saved layouts, labels, and restore defaults remain available. Custom buttons work in the floating panel, side controls, and composer and send the configured combination without appending Enter.
Collapse terminal encoding guidance under How shortcuts work and shorten the dialog introduction. Prevent mobile slot sections from shrinking and keep the zoomed page stationary while the dialog scrolls. Load this dialog on demand using the existing settings-dialog pattern. Configuration drawer buttons retain left-aligned titles and descriptions. Remove the entire mobile Configuration footer, including Done, the status text, and its separator; the top close button remains available.
Unsupported combinations, such as Ctrl+1, identify the affected slot and key combination, explain the current terminal encoding limitation, and block saving. Character labels preserve case when it affects the sent bytes; compact default labels distinguish keys with multiple modifiers. Cmd/Meta, text macros, and multi-step sequences remain out of scope.
Closes #308.
Validation
bun run precommitthrough the pre-commit hook: formatting, lint, type checks, frontend build and existing asset budgets passed; 2365 tests passed, 2 skipped.bun run build:web: passed with existing asset budgets.The updated picker has not been verified on physical iOS Safari or Android Chrome devices.