Fix composer upload races and desktop downloads - #312
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
470cca3aabe52fd72c65a31168cf38cf57b8ba97: formatting, lint, full types/production build, site build, and the complete suite (2,367 passed, 2 skipped, 0 failed).bun run build:web, including unchanged asset budgets: initial JS gzip 207,864 / 207,872 bytes (8 bytes spare). A disposable 0.7.14 version simulation also passed; the branch remains 0.7.13.bun run build:site.bun run precommit: formatting, lint, full TypeScript checks, and embedded production web build passed. Aggregate tests: 2,103 passed, 2 skipped, 264 failed. The failing test-name set exactly matches the unmodified-main baseline (2,101 passed, 2 skipped, 264 failed); existing local socket/process environment restrictions remain, including when retried outside the normal sandbox. This is not a complete local precommit pass.Browser coverage limits
Automated component tests use real React with Happy DOM and mocked upload/delivery APIs. The cloud Chromium attempt to open the local harness was blocked by the browser client, so no actual-browser, native share-sheet, physical iOS/Android, or full-backend acceptance pass is claimed. The unrestricted aggregate suite passed in GitHub CI.