API: Don't emit namespacing macros if MLD_CONFIG_CONSTANTS_ONLY is set - #1400
Open
hanno-becker wants to merge 1 commit into
Open
API: Don't emit namespacing macros if MLD_CONFIG_CONSTANTS_ONLY is set#1400hanno-becker wants to merge 1 commit into
hanno-becker wants to merge 1 commit into
Conversation
The public header mldsa_native.h can be included with MLD_CONFIG_CONSTANTS_ONLY set to obtain constant definitions without the function API. However, it still emitted namespacing and qualification macros for the omitted function declarations, which are irrelevant in that mode. Move the hash-algorithm and domain-separation constants above the namespacing section. Then move the '#if !defined(MLD_CONFIG_CONSTANTS_ONLY)' guard upwards so a single block encompasses both namespacing and the function API. Keep the config-file include unconditional because the Memory Usage constants (MLD_TOTAL_ALLOC_*) still depend on MLD_CONFIG_KEYGEN_PCT in constants-only builds. Ported from mlkem-native. Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
Contributor
CBMC Results (ML-DSA-44, REDUCE-RAM)
Full Results (210 proofs)
|
Contributor
CBMC Results (ML-DSA-65, REDUCE-RAM)
Full Results (210 proofs)
|
Contributor
CBMC Results (ML-DSA-44)
Full Results (210 proofs)
|
Contributor
CBMC Results (ML-DSA-87, REDUCE-RAM)
Full Results (210 proofs)
|
Contributor
CBMC Results (ML-DSA-65)
Full Results (210 proofs)
|
Contributor
CBMC Results (ML-DSA-87)
Full Results (210 proofs)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public header mldsa_native.h can be included with MLD_CONFIG_CONSTANTS_ONLY set to obtain constant definitions without the function API. However, it still emitted namespacing and qualification macros for the omitted function declarations, which are irrelevant in that mode.
Move the hash-algorithm and domain-separation constants above the namespacing section. Then move the
'#if !defined(MLD_CONFIG_CONSTANTS_ONLY)' guard upwards so a single block encompasses both namespacing and the function API. Keep the config-file include unconditional because the Memory Usage constants (MLD_TOTAL_ALLOC_*) still depend on MLD_CONFIG_KEYGEN_PCT in constants-only builds.
Ports pq-code-package/mlkem-native#1870