Refactor mlk_polymat_permute_bitrev_to_custom

[mkannwischer]

• Resolves CBMC: Refactor mlk_polymat_permute_bitrev_to_custom and prove monolithically #1375

This commit refactors mlk_polymat_permute_bitrev_to_custom to not require the helper function mlk_polyvec_permute_bitrev_to_custom. The function was only needed due CBMC limitations.

[mkannwischer]

This proves fine in a couple of seconds for MLKEM_K=3, but spins forever for MLKEM_K=2 and MLKEM_K=4:

$ tests cbmc -p polymat_permute_bitrev_to_custom_native --k 3

For your convenience, the output of this run will be symbolically linked to  /Users/matthiaskannwischer/git/native/mlkem-native/proofs/cbmc/output/latest/html/index.html 

Configuring CBMC proofs: 1 / 1
[16/16] mlk_polymat_permute_bitrev_to_custom_native: generating report                                                                                                                                                                                                                                                                                                  
Report was rendered at file:///Users/matthiaskannwischer/git/native/mlkem-native/proofs/cbmc/output/latest/html/index.html
## Summary of CBMC proof results

| Status  | Count |
|---------|-------|
| Success | 1     |

| Proof                                       | Status  | Duration (in s) |
|---------------------------------------------|---------|-----------------|
| mlk_polymat_permute_bitrev_to_custom_native | Success | 6               |


WARNING:root:$GITHUB_STEP_SUMMARY not set, not writing summary file
All good!
Matthiass-MacBook-Pro:mlkem-native matthiaskannwischer$ tests cbmc -p polymat_permute_bitrev_to_custom_native --k 2

For your convenience, the output of this run will be symbolically linked to  /Users/matthiaskannwischer/git/native/mlkem-native/proofs/cbmc/output/latest/html/index.html 

Configuring CBMC proofs: 1 / 1
[14/16] mlk_polymat_permute_bitrev_to_custom_native: printing safety properties  

Makes no sense to me.
@rod-chapman, any ideas?

[rod-chapman]

Since we introduced struct wrappers around mlk_polyvec and mlk_polymat, the latter is now a struct that contains a K-element array of structs, each of which contains a single K-element array of mlk_poly.

This new code is trying to treat that as a single-dimensional array of K*K mlk_poly's by the look of it. That's bound to cause serious complications for CBMC.

Try a nested loop, so the code structure matches the data structure.

[hanno-becker]

@mkannwischer Can you comment on state/plans for this?

[mkannwischer]

@mkannwischer Can you comment on state/plans for this?

See pq-code-package/mldsa-native#770 - we are waiting for diffblue/cbmc#8705 to be merged.

@willieyz, could you rebase this PR and also include the experimental branch of CBMC so we can confirm that the proofs pass with that version.

[willieyz]

@mkannwischer Can you comment on state/plans for this?

See pq-code-package/mldsa-native#770 - we are waiting for diffblue/cbmc#8705 to be merged.

@willieyz, could you rebase this PR and also include the experimental branch of CBMC so we can confirm that the proofs pass with that version.

Yes, I can do it.

[hanno-becker]

This seems no longer relevant; closing. @mkannwischer reopen if you disagree and foresee time to work on this.

[mkannwischer]

This seems no longer relevant; closing. @mkannwischer reopen if you disagree and foresee time to work on this.

Why is this no longer relevant? I still want to do this refactoring as soon as the CBMC fix has been merged.

[rod-chapman]

Agree. We will return to this when we get a new release of CBMC. The helper function could be removed if and when CBMC can handle a nested loop efficiently.

[oqs-bot]

CBMC Results (ML-KEM-1024)

⚠️ Attention Required

Proof	Status	Current	Previous	Change
mlk_polyvec_basemul_acc_montgomery_cached_c	⚠️	149s	79s	+89%

Full Results (190 proofs)

Proof	Status	Current	Previous	Change
**TOTAL**	✅	1965s	1885s	+4.2%
mlk_indcpa_enc	✅	464s	402s	+15%
mlk_indcpa_keypair_derand	✅	203s	176s	+15%
mlk_rej_uniform_c	✅	193s	144s	+34%
mlk_polyvec_basemul_acc_montgomery_cached_c	⚠️	149s	79s	+89%
mlk_polymat_permute_bitrev_to_custom_native	✅	74s	-	new
rej_uniform_native_aarch64	✅	42s	53s	-21%
mlk_ntt_layer	✅	41s	38s	+8%
mlk_poly_reduce_native	✅	41s	40s	+2%
mlk_poly_rej_uniform	✅	38s	161s	-76%
rej_uniform_native_x86_64	✅	37s	67s	-45%
poly_ntt_native	✅	34s	43s	-21%
polyvec_basemul_acc_montgomery_cached_native	✅	31s	31s	+0%
mlk_keccak_squeezeblocks_x4	✅	23s	26s	-12%
keccakf1600x4_permute_native_x4	✅	16s	15s	+7%
mlk_indcpa_dec	✅	16s	11s	+45%
mlk_polyvec_add	✅	16s	18s	-11%
mlk_poly_decompress_d5_native	✅	15s	18s	-17%
mlk_poly_decompress_d11_native	✅	13s	16s	-19%
kem_dec	✅	9s	5s	+80%
mlk_keccak_squeezeblocks	✅	9s	9s	+0%
mlk_poly_frombytes_native	✅	9s	10s	-10%
mlk_poly_frommsg	✅	9s	10s	-10%
mlk_keccak_squeeze_once	✅	8s	10s	-20%
mlk_poly_rej_uniform_x4	✅	8s	7s	+14%
mlk_invntt_layer	✅	7s	6s	+17%
mlk_ntt_butterfly_block	✅	7s	9s	-22%
mlk_poly_ntt	✅	7s	8s	-12%
mlk_poly_sub	✅	7s	8s	-12%
kem_enc_derand	✅	6s	3s	+100%
mlk_gen_matrix_serial	✅	6s	4s	+50%
mlk_keccakf1600_permute_c	✅	6s	6s	+0%
mlk_poly_add	✅	6s	5s	+20%
mlk_polyvec_basemul_acc_montgomery_cached	✅	6s	2s	+200%
poly_frombytes_native_x86_64	✅	6s	5s	+20%
mlk_gen_matrix	✅	5s	2s	+150%
mlk_keccak_absorb_once_x4	✅	5s	5s	+0%
mlk_keccakf1600x4_xor_bytes	✅	5s	2s	+150%
mlk_poly_compress_d11_native	✅	5s	3s	+67%
mlk_poly_decompress_d4_native	✅	5s	3s	+67%
mlk_polyvec_invntt_tomont	✅	5s	1s	+400%
mlk_polyvec_mulcache_compute	✅	5s	4s	+25%
mlk_rej_uniform	✅	5s	2s	+150%
mlk_shake256x4	✅	5s	4s	+25%
poly_decompress_d11_native_x86_64	✅	5s	5s	+0%
poly_decompress_d5_native_x86_64	✅	5s	5s	+0%
poly_mulcache_compute_native_aarch64	✅	5s	3s	+67%
poly_mulcache_compute_native_x86_64	✅	5s	5s	+0%
poly_reduce_native_aarch64	✅	5s	2s	+150%
intt_native_aarch64	✅	4s	3s	+33%
kem_enc	✅	4s	2s	+100%
kem_keypair_derand	✅	4s	1s	+300%
mlk_check_pct	✅	4s	1s	+300%
mlk_ct_cmask_nonzero_u8	✅	4s	1s	+300%
mlk_ct_cmov_zero	✅	4s	3s	+33%
mlk_ct_get_optblocker_i32	✅	4s	3s	+33%
mlk_keccakf1600x4_extract_bytes_c	✅	4s	3s	+33%
mlk_matvec_mul	✅	4s	5s	-20%
mlk_poly_cbd_eta1	✅	4s	3s	+33%
mlk_poly_compress_d10_c	✅	4s	3s	+33%
mlk_poly_compress_d4_c	✅	4s	4s	+0%
mlk_poly_invntt_tomont	✅	4s	3s	+33%
mlk_poly_tobytes_c	✅	4s	4s	+0%
mlk_poly_tomont_native	✅	4s	4s	+0%
mlk_scalar_decompress_d10	✅	4s	2s	+100%
mlk_shake128x4_squeezeblocks	✅	4s	2s	+100%
mlk_value_barrier_u32	✅	4s	3s	+33%
poly_compress_d4_native_x86_64	✅	4s	2s	+100%
rej_uniform_native	✅	4s	1s	+300%
keccak_f1600_x1_native_aarch64	✅	3s	1s	+200%
keccak_f1600_x1_native_aarch64_v84a	✅	3s	2s	+50%
mlk_barrett_reduce	✅	3s	2s	+50%
mlk_ct_get_optblocker_u32	✅	3s	3s	+0%
mlk_keccak_absorb_once	✅	3s	4s	-25%
mlk_keccakf1600_extract_bytes	✅	3s	2s	+50%
mlk_keccakf1600_extract_bytes (big endian)	✅	3s	2s	+50%
mlk_poly_compress_d10_native	✅	3s	3s	+0%
mlk_poly_compress_dv	✅	3s	1s	+200%
mlk_poly_decompress_d11	✅	3s	3s	+0%
mlk_poly_decompress_d11_c	✅	3s	2s	+50%
mlk_poly_decompress_dv	✅	3s	2s	+50%
mlk_poly_frombytes	✅	3s	2s	+50%
mlk_poly_frombytes_c	✅	3s	3s	+0%
mlk_poly_getnoise_eta1122_4x	✅	3s	3s	+0%
mlk_poly_getnoise_eta1_4x	✅	3s	2s	+50%
mlk_poly_getnoise_eta1_4x_native	✅	3s	3s	+0%
mlk_poly_invntt_tomont_c	✅	3s	2s	+50%
mlk_poly_mulcache_compute_c	✅	3s	3s	+0%
mlk_poly_mulcache_compute_native	✅	3s	3s	+0%
mlk_poly_ntt_c	✅	3s	1s	+200%
mlk_poly_tomont	✅	3s	2s	+50%
mlk_poly_tomsg	✅	3s	3s	+0%
mlk_polyvec_frombytes	✅	3s	5s	-40%
mlk_polyvec_ntt	✅	3s	12s	-75%
mlk_polyvec_reduce	✅	3s	2s	+50%
mlk_scalar_compress_d5	✅	3s	4s	-25%
mlk_scalar_decompress_d11	✅	3s	2s	+50%
mlk_scalar_decompress_d4	✅	3s	3s	+0%
mlk_shake128x4_absorb_once	✅	3s	2s	+50%
mlk_value_barrier_i32	✅	3s	3s	+0%
mlk_value_barrier_u8	✅	3s	1s	+200%
ntt_native_aarch64	✅	3s	3s	+0%
poly_decompress_d10_native_x86_64	✅	3s	4s	-25%
poly_decompress_d4_native_x86_64	✅	3s	2s	+50%
poly_reduce_native_x86_64	✅	3s	3s	+0%
poly_tomont_native_x86_64	✅	3s	2s	+50%
polyvec_basemul_acc_montgomery_cached_k2_native_aarch64	✅	3s	1s	+200%
polyvec_basemul_acc_montgomery_cached_k3_native_aarch64	✅	3s	2s	+50%
intt_native_x86_64	✅	2s	2s	+0%
keccak_f1600_x4_native_aarch64_v84a	✅	2s	3s	-33%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid	✅	2s	3s	-33%
keccak_f1600_x4_native_avx2	✅	2s	2s	+0%
keccakf1600_permute_native	✅	2s	2s	+0%
kem_check_pk	✅	2s	4s	-50%
kem_keypair	✅	2s	2s	+0%
mlk_ct_cmask_neg_i16	✅	2s	3s	-33%
mlk_ct_memcmp	✅	2s	3s	-33%
mlk_ct_sel_int16	✅	2s	4s	-50%
mlk_ct_sel_uint8	✅	2s	2s	+0%
mlk_enc_getnoise_eta1_eta2	✅	2s	4s	-50%
mlk_fqmul	✅	2s	20s	-90%
mlk_keccakf1600_permute	✅	2s	2s	+0%
mlk_keccakf1600_xor_bytes (big endian)	✅	2s	2s	+0%
mlk_keccakf1600x4_extract_bytes	✅	2s	2s	+0%
mlk_keypair_getnoise_eta1	✅	2s	5s	-60%
mlk_montgomery_reduce	✅	2s	2s	+0%
mlk_poly_cbd_eta2	✅	2s	3s	-33%
mlk_poly_compress_d10	✅	2s	2s	+0%
mlk_poly_compress_d11_c	✅	2s	4s	-50%
mlk_poly_compress_d5_c	✅	2s	4s	-50%
mlk_poly_compress_d5_native	✅	2s	4s	-50%
mlk_poly_compress_du	✅	2s	2s	+0%
mlk_poly_decompress_d10	✅	2s	2s	+0%
mlk_poly_decompress_d10_native	✅	2s	2s	+0%
mlk_poly_decompress_d4_c	✅	2s	4s	-50%
mlk_poly_decompress_d5	✅	2s	3s	-33%
mlk_poly_decompress_d5_c	✅	2s	2s	+0%
mlk_poly_getnoise_eta2	✅	2s	1s	+100%
mlk_poly_reduce	✅	2s	2s	+0%
mlk_poly_tobytes	✅	2s	3s	-33%
mlk_poly_tobytes_native	✅	2s	1s	+100%
mlk_poly_tomont_c	✅	2s	3s	-33%
mlk_polymat_permute_bitrev_to_custom	✅	2s	5s	-60%
mlk_polyvec_decompress_du	✅	2s	2s	+0%
mlk_scalar_compress_d1	✅	2s	3s	-33%
mlk_scalar_compress_d10	✅	2s	2s	+0%
mlk_scalar_compress_d11	✅	2s	4s	-50%
mlk_scalar_compress_d4	✅	2s	1s	+100%
mlk_scalar_decompress_d5	✅	2s	2s	+0%
mlk_sha3_256	✅	2s	2s	+0%
mlk_sha3_512	✅	2s	1s	+100%
mlk_shake128_absorb_once	✅	2s	2s	+0%
ntt_native_x86_64	✅	2s	2s	+0%
nttunpack_native_x86_64	✅	2s	2s	+0%
poly_compress_d10_native_x86_64	✅	2s	2s	+0%
poly_compress_d5_native_x86_64	✅	2s	4s	-50%
poly_getnoise_eta1122_4x_native	✅	2s	3s	-33%
polyvec_basemul_acc_montgomery_cached_k2_native_x86_64	✅	2s	2s	+0%
polyvec_basemul_acc_montgomery_cached_k3_native_x86_64	✅	2s	2s	+0%
polyvec_basemul_acc_montgomery_cached_k4_native_aarch64	✅	2s	2s	+0%
sys_check_capability	✅	2s	2s	+0%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid	✅	1s	3s	-67%
keccakf1600x4_extract_bytes_native	✅	1s	2s	-50%
keccakf1600x4_xor_bytes_native	✅	1s	2s	-50%
kem_check_sk	✅	1s	3s	-67%
mlk_ct_cmask_nonzero_u16	✅	1s	2s	-50%
mlk_ct_get_optblocker_u8	✅	1s	2s	-50%
mlk_keccakf1600_xor_bytes	✅	1s	1s	+0%
mlk_keccakf1600x4_permute	✅	1s	2s	-50%
mlk_keccakf1600x4_xor_bytes_c	✅	1s	5s	-80%
mlk_poly_compress_d11	✅	1s	3s	-67%
mlk_poly_compress_d4	✅	1s	3s	-67%
mlk_poly_compress_d4_native	✅	1s	2s	-50%
mlk_poly_compress_d5	✅	1s	5s	-80%
mlk_poly_decompress_d10_c	✅	1s	2s	-50%
mlk_poly_decompress_d4	✅	1s	3s	-67%
mlk_poly_decompress_du	✅	1s	1s	+0%
mlk_poly_mulcache_compute	✅	1s	2s	-50%
mlk_poly_reduce_c	✅	1s	1s	+0%
mlk_polyvec_compress_du	✅	1s	3s	-67%
mlk_polyvec_tobytes	✅	1s	1s	+0%
mlk_polyvec_tomont	✅	1s	2s	-50%
mlk_scalar_signed_to_unsigned_q	✅	1s	3s	-67%
mlk_shake128_squeezeblocks	✅	1s	1s	+0%
mlk_shake256	✅	1s	1s	+0%
poly_compress_d11_native_x86_64	✅	1s	3s	-67%
poly_invntt_tomont_native	✅	1s	3s	-67%
poly_tobytes_native_aarch64	✅	1s	3s	-67%
poly_tobytes_native_x86_64	✅	1s	3s	-67%
poly_tomont_native_aarch64	✅	1s	3s	-67%
polyvec_basemul_acc_montgomery_cached_k4_native_x86_64	✅	1s	2s	-50%

[oqs-bot]

CBMC Results (ML-KEM-512)

Full Results (190 proofs)

Proof	Status	Current	Previous	Change
**TOTAL**	✅	1552s	1614s	-3.8%
mlk_indcpa_enc	✅	382s	255s	+50%
mlk_rej_uniform_c	✅	161s	135s	+19%
mlk_indcpa_keypair_derand	✅	82s	213s	-62%
mlk_polyvec_basemul_acc_montgomery_cached_c	✅	65s	55s	+18%
rej_uniform_native_aarch64	✅	46s	43s	+7%
poly_ntt_native	✅	40s	45s	-11%
mlk_poly_rej_uniform	✅	38s	150s	-75%
rej_uniform_native_x86_64	✅	37s	57s	-35%
mlk_ntt_layer	✅	36s	32s	+12%
mlk_poly_reduce_native	✅	35s	35s	+0%
mlk_polymat_permute_bitrev_to_custom_native	✅	31s	-	new
mlk_keccak_squeezeblocks_x4	✅	24s	26s	-8%
mlk_indcpa_dec	✅	20s	14s	+43%
keccakf1600x4_permute_native_x4	✅	15s	16s	-6%
mlk_poly_decompress_d10_native	✅	15s	15s	+0%
mlk_poly_decompress_d4_native	✅	15s	14s	+7%
mlk_polyvec_add	✅	12s	11s	+9%
polyvec_basemul_acc_montgomery_cached_native	✅	10s	8s	+25%
mlk_keccak_squeeze_once	✅	9s	8s	+12%
mlk_keccak_squeezeblocks	✅	9s	9s	+0%
mlk_poly_frommsg	✅	9s	10s	-10%
mlk_ntt_butterfly_block	✅	8s	9s	-11%
mlk_poly_add	✅	8s	4s	+100%
poly_decompress_d10_native_x86_64	✅	8s	9s	-11%
mlk_poly_rej_uniform_x4	✅	7s	8s	-12%
mlk_poly_sub	✅	7s	6s	+17%
kem_dec	✅	6s	5s	+20%
kem_enc	✅	6s	2s	+200%
mlk_keccak_absorb_once_x4	✅	6s	5s	+20%
mlk_poly_frombytes_native	✅	6s	8s	-25%
mlk_poly_ntt	✅	6s	5s	+20%
mlk_ct_cmov_zero	✅	5s	3s	+67%
mlk_enc_getnoise_eta1_eta2	✅	5s	2s	+150%
mlk_fqmul	✅	5s	17s	-71%
mlk_invntt_layer	✅	5s	4s	+25%
mlk_poly_cbd_eta2	✅	5s	3s	+67%
mlk_poly_getnoise_eta2	✅	5s	3s	+67%
mlk_poly_mulcache_compute_native	✅	5s	2s	+150%
mlk_keccak_absorb_once	✅	4s	3s	+33%
mlk_keccakf1600_extract_bytes (big endian)	✅	4s	5s	-20%
mlk_keypair_getnoise_eta1	✅	4s	1s	+300%
mlk_matvec_mul	✅	4s	3s	+33%
mlk_montgomery_reduce	✅	4s	2s	+100%
mlk_poly_compress_d10_c	✅	4s	2s	+100%
mlk_poly_compress_d5	✅	4s	2s	+100%
mlk_poly_compress_d5_c	✅	4s	3s	+33%
mlk_poly_mulcache_compute_c	✅	4s	4s	+0%
mlk_polyvec_basemul_acc_montgomery_cached	✅	4s	1s	+300%
mlk_shake128x4_absorb_once	✅	4s	2s	+100%
mlk_shake256x4	✅	4s	5s	-20%
mlk_value_barrier_u8	✅	4s	4s	+0%
nttunpack_native_x86_64	✅	4s	2s	+100%
poly_decompress_d11_native_x86_64	✅	4s	1s	+300%
poly_decompress_d4_native_x86_64	✅	4s	4s	+0%
poly_frombytes_native_x86_64	✅	4s	5s	-20%
poly_invntt_tomont_native	✅	4s	2s	+100%
poly_mulcache_compute_native_x86_64	✅	4s	1s	+300%
poly_tomont_native_x86_64	✅	4s	2s	+100%
polyvec_basemul_acc_montgomery_cached_k2_native_aarch64	✅	4s	3s	+33%
polyvec_basemul_acc_montgomery_cached_k4_native_aarch64	✅	4s	3s	+33%
sys_check_capability	✅	4s	1s	+300%
intt_native_aarch64	✅	3s	2s	+50%
keccakf1600x4_xor_bytes_native	✅	3s	1s	+200%
mlk_ct_cmask_neg_i16	✅	3s	3s	+0%
mlk_ct_get_optblocker_u32	✅	3s	3s	+0%
mlk_ct_memcmp	✅	3s	3s	+0%
mlk_gen_matrix	✅	3s	2s	+50%
mlk_gen_matrix_serial	✅	3s	3s	+0%
mlk_keccakf1600_permute	✅	3s	1s	+200%
mlk_keccakf1600_permute_c	✅	3s	5s	-40%
mlk_keccakf1600x4_extract_bytes_c	✅	3s	3s	+0%
mlk_keccakf1600x4_permute	✅	3s	4s	-25%
mlk_keccakf1600x4_xor_bytes	✅	3s	2s	+50%
mlk_poly_cbd_eta1	✅	3s	2s	+50%
mlk_poly_compress_d10	✅	3s	4s	-25%
mlk_poly_compress_d4_native	✅	3s	2s	+50%
mlk_poly_decompress_d11_c	✅	3s	2s	+50%
mlk_poly_decompress_d11_native	✅	3s	3s	+0%
mlk_poly_decompress_d5	✅	3s	1s	+200%
mlk_poly_decompress_d5_c	✅	3s	1s	+200%
mlk_poly_frombytes	✅	3s	1s	+200%
mlk_poly_frombytes_c	✅	3s	4s	-25%
mlk_poly_getnoise_eta1122_4x	✅	3s	3s	+0%
mlk_poly_getnoise_eta1_4x_native	✅	3s	2s	+50%
mlk_poly_ntt_c	✅	3s	2s	+50%
mlk_poly_tobytes_native	✅	3s	2s	+50%
mlk_poly_tomont_native	✅	3s	2s	+50%
mlk_poly_tomsg	✅	3s	3s	+0%
mlk_polymat_permute_bitrev_to_custom	✅	3s	2s	+50%
mlk_polyvec_ntt	✅	3s	1s	+200%
mlk_polyvec_reduce	✅	3s	2s	+50%
mlk_scalar_compress_d11	✅	3s	2s	+50%
mlk_scalar_compress_d5	✅	3s	2s	+50%
mlk_scalar_decompress_d11	✅	3s	2s	+50%
mlk_scalar_decompress_d4	✅	3s	3s	+0%
mlk_scalar_decompress_d5	✅	3s	3s	+0%
mlk_shake128_squeezeblocks	✅	3s	3s	+0%
poly_decompress_d5_native_x86_64	✅	3s	2s	+50%
poly_getnoise_eta1122_4x_native	✅	3s	1s	+200%
poly_reduce_native_aarch64	✅	3s	1s	+200%
polyvec_basemul_acc_montgomery_cached_k3_native_aarch64	✅	3s	3s	+0%
rej_uniform_native	✅	3s	1s	+200%
keccak_f1600_x1_native_aarch64_v84a	✅	2s	2s	+0%
keccak_f1600_x4_native_aarch64_v84a	✅	2s	3s	-33%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid	✅	2s	3s	-33%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid	✅	2s	3s	-33%
keccakf1600x4_extract_bytes_native	✅	2s	1s	+100%
kem_check_pk	✅	2s	4s	-50%
kem_check_sk	✅	2s	2s	+0%
kem_keypair	✅	2s	4s	-50%
kem_keypair_derand	✅	2s	3s	-33%
mlk_barrett_reduce	✅	2s	2s	+0%
mlk_check_pct	✅	2s	5s	-60%
mlk_ct_cmask_nonzero_u16	✅	2s	2s	+0%
mlk_ct_get_optblocker_u8	✅	2s	2s	+0%
mlk_keccakf1600_xor_bytes	✅	2s	1s	+100%
mlk_keccakf1600_xor_bytes (big endian)	✅	2s	2s	+0%
mlk_keccakf1600x4_xor_bytes_c	✅	2s	2s	+0%
mlk_poly_compress_d10_native	✅	2s	1s	+100%
mlk_poly_compress_d11	✅	2s	3s	-33%
mlk_poly_compress_d11_c	✅	2s	2s	+0%
mlk_poly_compress_d4	✅	2s	3s	-33%
mlk_poly_compress_dv	✅	2s	3s	-33%
mlk_poly_decompress_d10	✅	2s	2s	+0%
mlk_poly_decompress_d10_c	✅	2s	4s	-50%
mlk_poly_decompress_d4	✅	2s	3s	-33%
mlk_poly_decompress_d5_native	✅	2s	2s	+0%
mlk_poly_decompress_du	✅	2s	2s	+0%
mlk_poly_decompress_dv	✅	2s	2s	+0%
mlk_poly_getnoise_eta1_4x	✅	2s	5s	-60%
mlk_poly_invntt_tomont	✅	2s	2s	+0%
mlk_poly_invntt_tomont_c	✅	2s	3s	-33%
mlk_poly_reduce	✅	2s	1s	+100%
mlk_poly_tobytes	✅	2s	3s	-33%
mlk_poly_tomont	✅	2s	1s	+100%
mlk_poly_tomont_c	✅	2s	2s	+0%
mlk_polyvec_invntt_tomont	✅	2s	3s	-33%
mlk_polyvec_mulcache_compute	✅	2s	5s	-60%
mlk_rej_uniform	✅	2s	5s	-60%
mlk_scalar_compress_d10	✅	2s	2s	+0%
mlk_scalar_compress_d4	✅	2s	1s	+100%
mlk_scalar_decompress_d10	✅	2s	2s	+0%
mlk_scalar_signed_to_unsigned_q	✅	2s	1s	+100%
mlk_shake256	✅	2s	2s	+0%
mlk_value_barrier_i32	✅	2s	2s	+0%
ntt_native_x86_64	✅	2s	2s	+0%
poly_compress_d10_native_x86_64	✅	2s	3s	-33%
poly_compress_d4_native_x86_64	✅	2s	1s	+100%
poly_compress_d5_native_x86_64	✅	2s	2s	+0%
poly_mulcache_compute_native_aarch64	✅	2s	3s	-33%
poly_reduce_native_x86_64	✅	2s	2s	+0%
poly_tobytes_native_aarch64	✅	2s	2s	+0%
poly_tobytes_native_x86_64	✅	2s	1s	+100%
poly_tomont_native_aarch64	✅	2s	2s	+0%
polyvec_basemul_acc_montgomery_cached_k2_native_x86_64	✅	2s	3s	-33%
polyvec_basemul_acc_montgomery_cached_k3_native_x86_64	✅	2s	2s	+0%
polyvec_basemul_acc_montgomery_cached_k4_native_x86_64	✅	2s	2s	+0%
intt_native_x86_64	✅	1s	2s	-50%
keccak_f1600_x1_native_aarch64	✅	1s	2s	-50%
keccak_f1600_x4_native_avx2	✅	1s	2s	-50%
keccakf1600_permute_native	✅	1s	1s	+0%
kem_enc_derand	✅	1s	3s	-67%
mlk_ct_cmask_nonzero_u8	✅	1s	1s	+0%
mlk_ct_get_optblocker_i32	✅	1s	2s	-50%
mlk_ct_sel_int16	✅	1s	1s	+0%
mlk_ct_sel_uint8	✅	1s	2s	-50%
mlk_keccakf1600_extract_bytes	✅	1s	2s	-50%
mlk_keccakf1600x4_extract_bytes	✅	1s	2s	-50%
mlk_poly_compress_d11_native	✅	1s	3s	-67%
mlk_poly_compress_d4_c	✅	1s	3s	-67%
mlk_poly_compress_d5_native	✅	1s	3s	-67%
mlk_poly_compress_du	✅	1s	3s	-67%
mlk_poly_decompress_d11	✅	1s	2s	-50%
mlk_poly_decompress_d4_c	✅	1s	7s	-86%
mlk_poly_mulcache_compute	✅	1s	2s	-50%
mlk_poly_reduce_c	✅	1s	3s	-67%
mlk_poly_tobytes_c	✅	1s	3s	-67%
mlk_polyvec_compress_du	✅	1s	2s	-50%
mlk_polyvec_decompress_du	✅	1s	2s	-50%
mlk_polyvec_frombytes	✅	1s	2s	-50%
mlk_polyvec_tobytes	✅	1s	3s	-67%
mlk_polyvec_tomont	✅	1s	1s	+0%
mlk_scalar_compress_d1	✅	1s	2s	-50%
mlk_sha3_256	✅	1s	2s	-50%
mlk_sha3_512	✅	1s	2s	-50%
mlk_shake128_absorb_once	✅	1s	3s	-67%
mlk_shake128x4_squeezeblocks	✅	1s	1s	+0%
mlk_value_barrier_u32	✅	1s	3s	-67%
ntt_native_aarch64	✅	1s	2s	-50%
poly_compress_d11_native_x86_64	✅	1s	2s	-50%

[oqs-bot]

CBMC Results (ML-KEM-768)

⚠️ Attention Required

Proof	Status	Current	Previous	Change
mlk_indcpa_dec	⚠️	21s	10s	+110%
mlk_polyvec_basemul_acc_montgomery_cached_c	⚠️	86s	46s	+87%
mlk_rej_uniform_c	⚠️	176s	114s	+54%
polyvec_basemul_acc_montgomery_cached_native	⚠️	22s	14s	+57%

Full Results (190 proofs)

Proof	Status	Current	Previous	Change
**TOTAL**	✅	1819s	1645s	+10.6%
mlk_indcpa_enc	✅	368s	252s	+46%
mlk_indcpa_keypair_derand	✅	212s	318s	-33%
mlk_rej_uniform_c	⚠️	176s	114s	+54%
mlk_polyvec_basemul_acc_montgomery_cached_c	⚠️	86s	46s	+87%
mlk_polymat_permute_bitrev_to_custom_native	✅	57s	-	new
rej_uniform_native_aarch64	✅	48s	45s	+7%
poly_ntt_native	✅	45s	39s	+15%
rej_uniform_native_x86_64	✅	43s	55s	-22%
mlk_ntt_layer	✅	40s	29s	+38%
mlk_poly_reduce_native	✅	39s	34s	+15%
mlk_poly_rej_uniform	✅	39s	129s	-70%
mlk_keccak_squeezeblocks_x4	✅	27s	24s	+12%
polyvec_basemul_acc_montgomery_cached_native	⚠️	22s	14s	+57%
mlk_indcpa_dec	⚠️	21s	10s	+110%
keccakf1600x4_permute_native_x4	✅	17s	21s	-19%
mlk_poly_decompress_d4_native	✅	16s	12s	+33%
mlk_poly_decompress_d10_native	✅	15s	15s	+0%
mlk_polyvec_add	✅	14s	12s	+17%
mlk_poly_frommsg	✅	12s	9s	+33%
mlk_keccak_absorb_once_x4	✅	10s	5s	+100%
mlk_ntt_butterfly_block	✅	10s	7s	+43%
mlk_keccak_squeezeblocks	✅	9s	8s	+12%
mlk_poly_frombytes_native	✅	9s	8s	+12%
mlk_poly_ntt	✅	9s	5s	+80%
kem_dec	✅	8s	5s	+60%
mlk_keccak_squeeze_once	✅	8s	7s	+14%
mlk_poly_rej_uniform_x4	✅	8s	5s	+60%
mlk_invntt_layer	✅	7s	4s	+75%
mlk_keccak_absorb_once	✅	6s	3s	+100%
mlk_keccakf1600_permute_c	✅	6s	6s	+0%
poly_frombytes_native_x86_64	✅	6s	5s	+20%
intt_native_aarch64	✅	5s	5s	+0%
keccak_f1600_x4_native_avx2	✅	5s	2s	+150%
kem_enc_derand	✅	5s	3s	+67%
mlk_poly_add	✅	5s	7s	-29%
mlk_poly_sub	✅	5s	10s	-50%
mlk_scalar_compress_d11	✅	5s	1s	+400%
mlk_shake128x4_absorb_once	✅	5s	3s	+67%
mlk_shake256	✅	5s	2s	+150%
mlk_shake256x4	✅	5s	3s	+67%
poly_decompress_d5_native_x86_64	✅	5s	4s	+25%
kem_enc	✅	4s	2s	+100%
kem_keypair_derand	✅	4s	2s	+100%
mlk_check_pct	✅	4s	3s	+33%
mlk_fqmul	✅	4s	16s	-75%
mlk_gen_matrix_serial	✅	4s	2s	+100%
mlk_keccakf1600x4_xor_bytes_c	✅	4s	1s	+300%
mlk_matvec_mul	✅	4s	4s	+0%
mlk_poly_compress_d10	✅	4s	2s	+100%
mlk_poly_compress_d11	✅	4s	1s	+300%
mlk_poly_compress_d4_native	✅	4s	3s	+33%
mlk_poly_compress_d5_c	✅	4s	1s	+300%
mlk_poly_decompress_d11	✅	4s	2s	+100%
mlk_poly_decompress_dv	✅	4s	2s	+100%
mlk_poly_frombytes_c	✅	4s	4s	+0%
mlk_poly_getnoise_eta1_4x	✅	4s	2s	+100%
mlk_poly_mulcache_compute	✅	4s	2s	+100%
mlk_polyvec_decompress_du	✅	4s	4s	+0%
mlk_polyvec_tobytes	✅	4s	1s	+300%
mlk_scalar_compress_d4	✅	4s	2s	+100%
mlk_scalar_decompress_d10	✅	4s	2s	+100%
mlk_scalar_signed_to_unsigned_q	✅	4s	5s	-20%
nttunpack_native_x86_64	✅	4s	3s	+33%
poly_compress_d11_native_x86_64	✅	4s	3s	+33%
poly_compress_d5_native_x86_64	✅	4s	2s	+100%
poly_decompress_d10_native_x86_64	✅	4s	5s	-20%
poly_decompress_d11_native_x86_64	✅	4s	1s	+300%
poly_decompress_d4_native_x86_64	✅	4s	6s	-33%
poly_mulcache_compute_native_x86_64	✅	4s	3s	+33%
poly_tomont_native_aarch64	✅	4s	1s	+300%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid	✅	3s	3s	+0%
keccakf1600x4_xor_bytes_native	✅	3s	2s	+50%
kem_check_pk	✅	3s	2s	+50%
kem_keypair	✅	3s	2s	+50%
mlk_ct_cmask_neg_i16	✅	3s	3s	+0%
mlk_ct_get_optblocker_u32	✅	3s	1s	+200%
mlk_ct_get_optblocker_u8	✅	3s	2s	+50%
mlk_keccakf1600_permute	✅	3s	1s	+200%
mlk_keccakf1600x4_extract_bytes	✅	3s	4s	-25%
mlk_keccakf1600x4_permute	✅	3s	4s	-25%
mlk_keypair_getnoise_eta1	✅	3s	2s	+50%
mlk_montgomery_reduce	✅	3s	1s	+200%
mlk_poly_compress_d10_c	✅	3s	2s	+50%
mlk_poly_compress_d4	✅	3s	3s	+0%
mlk_poly_compress_d4_c	✅	3s	1s	+200%
mlk_poly_compress_d5	✅	3s	2s	+50%
mlk_poly_decompress_d10	✅	3s	2s	+50%
mlk_poly_decompress_d10_c	✅	3s	1s	+200%
mlk_poly_decompress_d5_c	✅	3s	3s	+0%
mlk_poly_decompress_d5_native	✅	3s	3s	+0%
mlk_poly_decompress_du	✅	3s	1s	+200%
mlk_poly_frombytes	✅	3s	2s	+50%
mlk_poly_reduce_c	✅	3s	3s	+0%
mlk_poly_tobytes	✅	3s	3s	+0%
mlk_poly_tobytes_c	✅	3s	1s	+200%
mlk_poly_tomont_c	✅	3s	3s	+0%
mlk_polyvec_compress_du	✅	3s	1s	+200%
mlk_polyvec_frombytes	✅	3s	3s	+0%
mlk_polyvec_invntt_tomont	✅	3s	1s	+200%
mlk_polyvec_mulcache_compute	✅	3s	2s	+50%
mlk_polyvec_ntt	✅	3s	4s	-25%
mlk_scalar_compress_d10	✅	3s	2s	+50%
mlk_scalar_decompress_d4	✅	3s	2s	+50%
mlk_sha3_256	✅	3s	2s	+50%
mlk_shake128_squeezeblocks	✅	3s	3s	+0%
mlk_value_barrier_i32	✅	3s	2s	+50%
ntt_native_x86_64	✅	3s	3s	+0%
poly_compress_d10_native_x86_64	✅	3s	5s	-40%
poly_compress_d4_native_x86_64	✅	3s	3s	+0%
poly_reduce_native_x86_64	✅	3s	2s	+50%
polyvec_basemul_acc_montgomery_cached_k2_native_x86_64	✅	3s	4s	-25%
polyvec_basemul_acc_montgomery_cached_k3_native_x86_64	✅	3s	2s	+50%
polyvec_basemul_acc_montgomery_cached_k4_native_aarch64	✅	3s	1s	+200%
rej_uniform_native	✅	3s	2s	+50%
sys_check_capability	✅	3s	3s	+0%
intt_native_x86_64	✅	2s	3s	-33%
keccak_f1600_x1_native_aarch64	✅	2s	1s	+100%
keccak_f1600_x4_native_aarch64_v84a	✅	2s	2s	+0%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid	✅	2s	1s	+100%
kem_check_sk	✅	2s	2s	+0%
mlk_barrett_reduce	✅	2s	2s	+0%
mlk_ct_cmask_nonzero_u8	✅	2s	4s	-50%
mlk_ct_cmov_zero	✅	2s	3s	-33%
mlk_ct_sel_uint8	✅	2s	1s	+100%
mlk_enc_getnoise_eta1_eta2	✅	2s	3s	-33%
mlk_gen_matrix	✅	2s	2s	+0%
mlk_keccakf1600_extract_bytes	✅	2s	4s	-50%
mlk_keccakf1600_xor_bytes	✅	2s	3s	-33%
mlk_keccakf1600_xor_bytes (big endian)	✅	2s	1s	+100%
mlk_keccakf1600x4_xor_bytes	✅	2s	2s	+0%
mlk_poly_compress_d10_native	✅	2s	2s	+0%
mlk_poly_decompress_d11_c	✅	2s	3s	-33%
mlk_poly_decompress_d11_native	✅	2s	1s	+100%
mlk_poly_decompress_d4	✅	2s	3s	-33%
mlk_poly_decompress_d4_c	✅	2s	4s	-50%
mlk_poly_getnoise_eta1_4x_native	✅	2s	3s	-33%
mlk_poly_getnoise_eta2	✅	2s	2s	+0%
mlk_poly_invntt_tomont_c	✅	2s	2s	+0%
mlk_poly_mulcache_compute_c	✅	2s	2s	+0%
mlk_poly_mulcache_compute_native	✅	2s	1s	+100%
mlk_poly_ntt_c	✅	2s	1s	+100%
mlk_poly_reduce	✅	2s	2s	+0%
mlk_poly_tobytes_native	✅	2s	1s	+100%
mlk_poly_tomsg	✅	2s	3s	-33%
mlk_polyvec_basemul_acc_montgomery_cached	✅	2s	4s	-50%
mlk_polyvec_reduce	✅	2s	1s	+100%
mlk_polyvec_tomont	✅	2s	1s	+100%
mlk_rej_uniform	✅	2s	1s	+100%
mlk_scalar_compress_d1	✅	2s	2s	+0%
mlk_scalar_compress_d5	✅	2s	1s	+100%
mlk_scalar_decompress_d11	✅	2s	3s	-33%
mlk_scalar_decompress_d5	✅	2s	2s	+0%
mlk_sha3_512	✅	2s	3s	-33%
mlk_shake128_absorb_once	✅	2s	1s	+100%
mlk_value_barrier_u32	✅	2s	2s	+0%
mlk_value_barrier_u8	✅	2s	2s	+0%
ntt_native_aarch64	✅	2s	3s	-33%
poly_getnoise_eta1122_4x_native	✅	2s	1s	+100%
poly_invntt_tomont_native	✅	2s	2s	+0%
poly_mulcache_compute_native_aarch64	✅	2s	6s	-67%
poly_tobytes_native_aarch64	✅	2s	1s	+100%
poly_tobytes_native_x86_64	✅	2s	3s	-33%
poly_tomont_native_x86_64	✅	2s	1s	+100%
polyvec_basemul_acc_montgomery_cached_k3_native_aarch64	✅	2s	2s	+0%
polyvec_basemul_acc_montgomery_cached_k4_native_x86_64	✅	2s	2s	+0%
keccak_f1600_x1_native_aarch64_v84a	✅	1s	3s	-67%
keccakf1600_permute_native	✅	1s	3s	-67%
keccakf1600x4_extract_bytes_native	✅	1s	3s	-67%
mlk_ct_cmask_nonzero_u16	✅	1s	4s	-75%
mlk_ct_get_optblocker_i32	✅	1s	1s	+0%
mlk_ct_memcmp	✅	1s	4s	-75%
mlk_ct_sel_int16	✅	1s	3s	-67%
mlk_keccakf1600_extract_bytes (big endian)	✅	1s	2s	-50%
mlk_keccakf1600x4_extract_bytes_c	✅	1s	2s	-50%
mlk_poly_cbd_eta1	✅	1s	1s	+0%
mlk_poly_cbd_eta2	✅	1s	2s	-50%
mlk_poly_compress_d11_c	✅	1s	1s	+0%
mlk_poly_compress_d11_native	✅	1s	4s	-75%
mlk_poly_compress_d5_native	✅	1s	2s	-50%
mlk_poly_compress_du	✅	1s	1s	+0%
mlk_poly_compress_dv	✅	1s	1s	+0%
mlk_poly_decompress_d5	✅	1s	2s	-50%
mlk_poly_getnoise_eta1122_4x	✅	1s	1s	+0%
mlk_poly_invntt_tomont	✅	1s	4s	-75%
mlk_poly_tomont	✅	1s	1s	+0%
mlk_poly_tomont_native	✅	1s	3s	-67%
mlk_polymat_permute_bitrev_to_custom	✅	1s	3s	-67%
mlk_shake128x4_squeezeblocks	✅	1s	1s	+0%
poly_reduce_native_aarch64	✅	1s	2s	-50%
polyvec_basemul_acc_montgomery_cached_k2_native_aarch64	✅	1s	3s	-67%

[hanno-becker]

@mkannwischer I rebased this. Can you check that you're happy once CI is?