CBMC: Refine bounds for input and output of base multiplication - #906
CBMC: Refine bounds for input and output of base multiplication#906hanno-becker wants to merge 1 commit into
Conversation
1326e42 to
f9b25ee
Compare
There was a problem hiding this comment.
Mac Mini (M1, 2020) benchmarks
Details
| Benchmark suite | Current: ee52c4e | Previous: 8dba13b | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
12257 cycles |
12254 cycles |
1.00 |
ML-KEM-512 encaps |
14848 cycles |
14846 cycles |
1.00 |
ML-KEM-512 decaps |
19725 cycles |
19721 cycles |
1.00 |
ML-KEM-768 keypair |
21048 cycles |
21051 cycles |
1.00 |
ML-KEM-768 encaps |
23677 cycles |
23679 cycles |
1.00 |
ML-KEM-768 decaps |
30515 cycles |
30515 cycles |
1 |
ML-KEM-1024 keypair |
29977 cycles |
29978 cycles |
1.00 |
ML-KEM-1024 encaps |
34479 cycles |
34478 cycles |
1.00 |
ML-KEM-1024 decaps |
43430 cycles |
43442 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Intel Xeon 4th gen (c7i)
Details
| Benchmark suite | Current: 2984fbe | Previous: 0608277 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
11882 cycles |
11814 cycles |
1.01 |
ML-KEM-512 encaps |
13289 cycles |
13091 cycles |
1.02 |
ML-KEM-512 decaps |
17239 cycles |
17198 cycles |
1.00 |
ML-KEM-768 keypair |
19720 cycles |
19378 cycles |
1.02 |
ML-KEM-768 encaps |
21078 cycles |
20699 cycles |
1.02 |
ML-KEM-768 decaps |
26624 cycles |
26393 cycles |
1.01 |
ML-KEM-1024 keypair |
28312 cycles |
28230 cycles |
1.00 |
ML-KEM-1024 encaps |
30253 cycles |
30160 cycles |
1.00 |
ML-KEM-1024 decaps |
37612 cycles |
37619 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Intel Xeon 4th gen (c7i) (no-opt)
Details
| Benchmark suite | Current: 2984fbe | Previous: 0608277 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
27656 cycles |
27528 cycles |
1.00 |
ML-KEM-512 encaps |
34464 cycles |
34189 cycles |
1.01 |
ML-KEM-512 decaps |
44045 cycles |
43887 cycles |
1.00 |
ML-KEM-768 keypair |
44260 cycles |
44314 cycles |
1.00 |
ML-KEM-768 encaps |
54929 cycles |
54874 cycles |
1.00 |
ML-KEM-768 decaps |
68271 cycles |
68308 cycles |
1.00 |
ML-KEM-1024 keypair |
67587 cycles |
67436 cycles |
1.00 |
ML-KEM-1024 encaps |
78819 cycles |
78816 cycles |
1.00 |
ML-KEM-1024 decaps |
96111 cycles |
96150 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Arm Cortex-A55 (Snapdragon 888) benchmarks
Details
| Benchmark suite | Current: ee52c4e | Previous: 8dba13b | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
59336 cycles |
59330 cycles |
1.00 |
ML-KEM-512 encaps |
66928 cycles |
66920 cycles |
1.00 |
ML-KEM-512 decaps |
86001 cycles |
86014 cycles |
1.00 |
ML-KEM-768 keypair |
101044 cycles |
101087 cycles |
1.00 |
ML-KEM-768 encaps |
112086 cycles |
112317 cycles |
1.00 |
ML-KEM-768 decaps |
139218 cycles |
139358 cycles |
1.00 |
ML-KEM-1024 keypair |
153559 cycles |
153471 cycles |
1.00 |
ML-KEM-1024 encaps |
172905 cycles |
170285 cycles |
1.02 |
ML-KEM-1024 decaps |
210032 cycles |
207958 cycles |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
AMD EPYC 4th gen (c7a)
Details
| Benchmark suite | Current: 2984fbe | Previous: 0608277 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
12844 cycles |
12818 cycles |
1.00 |
ML-KEM-512 encaps |
14281 cycles |
14213 cycles |
1.00 |
ML-KEM-512 decaps |
19056 cycles |
18981 cycles |
1.00 |
ML-KEM-768 keypair |
21662 cycles |
21611 cycles |
1.00 |
ML-KEM-768 encaps |
22851 cycles |
22673 cycles |
1.01 |
ML-KEM-768 decaps |
29760 cycles |
29642 cycles |
1.00 |
ML-KEM-1024 keypair |
30561 cycles |
30460 cycles |
1.00 |
ML-KEM-1024 encaps |
32758 cycles |
32619 cycles |
1.00 |
ML-KEM-1024 decaps |
42208 cycles |
42024 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
AMD EPYC 3rd gen (c6a)
Details
| Benchmark suite | Current: 2984fbe | Previous: 0608277 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
14506 cycles |
14430 cycles |
1.01 |
ML-KEM-512 encaps |
16067 cycles |
15953 cycles |
1.01 |
ML-KEM-512 decaps |
21519 cycles |
21352 cycles |
1.01 |
ML-KEM-768 keypair |
23895 cycles |
23653 cycles |
1.01 |
ML-KEM-768 encaps |
25261 cycles |
25052 cycles |
1.01 |
ML-KEM-768 decaps |
33298 cycles |
32878 cycles |
1.01 |
ML-KEM-1024 keypair |
33747 cycles |
33529 cycles |
1.01 |
ML-KEM-1024 encaps |
36060 cycles |
35883 cycles |
1.00 |
ML-KEM-1024 decaps |
46499 cycles |
46302 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Intel Xeon 3rd gen (c6i)
Details
| Benchmark suite | Current: 2984fbe | Previous: 0608277 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
18012 cycles |
17951 cycles |
1.00 |
ML-KEM-512 encaps |
20181 cycles |
20119 cycles |
1.00 |
ML-KEM-512 decaps |
26910 cycles |
26773 cycles |
1.01 |
ML-KEM-768 keypair |
30869 cycles |
30083 cycles |
1.03 |
ML-KEM-768 encaps |
32097 cycles |
31885 cycles |
1.01 |
ML-KEM-768 decaps |
44369 cycles |
41521 cycles |
1.07 |
ML-KEM-1024 keypair |
42410 cycles |
42120 cycles |
1.01 |
ML-KEM-1024 encaps |
45721 cycles |
45813 cycles |
1.00 |
ML-KEM-1024 decaps |
58408 cycles |
58278 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Intel Xeon 3rd gen (c6i)'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.03.
| Benchmark suite | Current: 2984fbe | Previous: 0608277 | Ratio |
|---|---|---|---|
ML-KEM-768 decaps |
44369 cycles |
41521 cycles |
1.07 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
AMD EPYC 4th gen (c7a) (no-opt)
Details
| Benchmark suite | Current: 2984fbe | Previous: 0608277 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
36736 cycles |
36732 cycles |
1.00 |
ML-KEM-512 encaps |
42809 cycles |
42788 cycles |
1.00 |
ML-KEM-512 decaps |
55544 cycles |
55534 cycles |
1.00 |
ML-KEM-768 keypair |
58381 cycles |
58385 cycles |
1.00 |
ML-KEM-768 encaps |
67032 cycles |
67035 cycles |
1.00 |
ML-KEM-768 decaps |
83945 cycles |
84011 cycles |
1.00 |
ML-KEM-1024 keypair |
88541 cycles |
88488 cycles |
1.00 |
ML-KEM-1024 encaps |
99207 cycles |
99002 cycles |
1.00 |
ML-KEM-1024 decaps |
120514 cycles |
120405 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
AMD EPYC 3rd gen (c6a) (no-opt)
Details
| Benchmark suite | Current: 2984fbe | Previous: 0608277 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
40213 cycles |
39898 cycles |
1.01 |
ML-KEM-512 encaps |
48345 cycles |
48282 cycles |
1.00 |
ML-KEM-512 decaps |
61864 cycles |
61774 cycles |
1.00 |
ML-KEM-768 keypair |
62689 cycles |
62604 cycles |
1.00 |
ML-KEM-768 encaps |
75020 cycles |
74835 cycles |
1.00 |
ML-KEM-768 decaps |
92705 cycles |
92457 cycles |
1.00 |
ML-KEM-1024 keypair |
95554 cycles |
95266 cycles |
1.00 |
ML-KEM-1024 encaps |
110497 cycles |
110126 cycles |
1.00 |
ML-KEM-1024 decaps |
133215 cycles |
132700 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Graviton4
Details
| Benchmark suite | Current: 2984fbe | Previous: 0608277 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
17664 cycles |
17687 cycles |
1.00 |
ML-KEM-512 encaps |
20548 cycles |
20545 cycles |
1.00 |
ML-KEM-512 decaps |
27003 cycles |
27028 cycles |
1.00 |
ML-KEM-768 keypair |
29873 cycles |
29839 cycles |
1.00 |
ML-KEM-768 encaps |
32701 cycles |
32723 cycles |
1.00 |
ML-KEM-768 decaps |
41923 cycles |
41863 cycles |
1.00 |
ML-KEM-1024 keypair |
43715 cycles |
43694 cycles |
1.00 |
ML-KEM-1024 encaps |
48640 cycles |
48696 cycles |
1.00 |
ML-KEM-1024 decaps |
61390 cycles |
61378 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Intel Xeon 3rd gen (c6i) (no-opt)
Details
| Benchmark suite | Current: 2984fbe | Previous: 0608277 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
46949 cycles |
46967 cycles |
1.00 |
ML-KEM-512 encaps |
55709 cycles |
55697 cycles |
1.00 |
ML-KEM-512 decaps |
71513 cycles |
71394 cycles |
1.00 |
ML-KEM-768 keypair |
74347 cycles |
74347 cycles |
1 |
ML-KEM-768 encaps |
85920 cycles |
85936 cycles |
1.00 |
ML-KEM-768 decaps |
106934 cycles |
106925 cycles |
1.00 |
ML-KEM-1024 keypair |
111324 cycles |
111271 cycles |
1.00 |
ML-KEM-1024 encaps |
126039 cycles |
126002 cycles |
1.00 |
ML-KEM-1024 decaps |
152116 cycles |
152097 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Graviton4 (no-opt)
Details
| Benchmark suite | Current: 2984fbe | Previous: 0608277 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
35215 cycles |
35180 cycles |
1.00 |
ML-KEM-512 encaps |
40026 cycles |
39967 cycles |
1.00 |
ML-KEM-512 decaps |
50570 cycles |
50600 cycles |
1.00 |
ML-KEM-768 keypair |
56693 cycles |
56654 cycles |
1.00 |
ML-KEM-768 encaps |
64089 cycles |
63984 cycles |
1.00 |
ML-KEM-768 decaps |
78446 cycles |
78490 cycles |
1.00 |
ML-KEM-1024 keypair |
87373 cycles |
87513 cycles |
1.00 |
ML-KEM-1024 encaps |
96554 cycles |
96618 cycles |
1.00 |
ML-KEM-1024 decaps |
114862 cycles |
114683 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Graviton3
Details
| Benchmark suite | Current: ee52c4e | Previous: 8dba13b | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
18864 cycles |
18877 cycles |
1.00 |
ML-KEM-512 encaps |
22344 cycles |
22358 cycles |
1.00 |
ML-KEM-512 decaps |
29577 cycles |
29566 cycles |
1.00 |
ML-KEM-768 keypair |
32236 cycles |
32250 cycles |
1.00 |
ML-KEM-768 encaps |
35628 cycles |
35598 cycles |
1.00 |
ML-KEM-768 decaps |
45941 cycles |
45965 cycles |
1.00 |
ML-KEM-1024 keypair |
46491 cycles |
46487 cycles |
1.00 |
ML-KEM-1024 encaps |
52069 cycles |
52080 cycles |
1.00 |
ML-KEM-1024 decaps |
65916 cycles |
65962 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Graviton2
Details
| Benchmark suite | Current: ee52c4e | Previous: 8dba13b | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
29410 cycles |
29444 cycles |
1.00 |
ML-KEM-512 encaps |
34613 cycles |
34680 cycles |
1.00 |
ML-KEM-512 decaps |
45213 cycles |
45279 cycles |
1.00 |
ML-KEM-768 keypair |
50051 cycles |
50139 cycles |
1.00 |
ML-KEM-768 encaps |
55328 cycles |
55224 cycles |
1.00 |
ML-KEM-768 decaps |
70158 cycles |
70096 cycles |
1.00 |
ML-KEM-1024 keypair |
73082 cycles |
73098 cycles |
1.00 |
ML-KEM-1024 encaps |
81472 cycles |
81514 cycles |
1.00 |
ML-KEM-1024 decaps |
101379 cycles |
101471 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Graviton3 (no-opt)
Details
| Benchmark suite | Current: ee52c4e | Previous: 8dba13b | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
38966 cycles |
39685 cycles |
0.98 |
ML-KEM-512 encaps |
44939 cycles |
44864 cycles |
1.00 |
ML-KEM-512 decaps |
56734 cycles |
56842 cycles |
1.00 |
ML-KEM-768 keypair |
64234 cycles |
64182 cycles |
1.00 |
ML-KEM-768 encaps |
72031 cycles |
72669 cycles |
0.99 |
ML-KEM-768 decaps |
88070 cycles |
88056 cycles |
1.00 |
ML-KEM-1024 keypair |
96228 cycles |
96095 cycles |
1.00 |
ML-KEM-1024 encaps |
106307 cycles |
106211 cycles |
1.00 |
ML-KEM-1024 decaps |
127120 cycles |
127057 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
SpacemiT K1 8 (Banana Pi F3) benchmarks
Details
| Benchmark suite | Current: ee52c4e | Previous: 8dba13b | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
225601 cycles |
225593 cycles |
1.00 |
ML-KEM-512 encaps |
271839 cycles |
271821 cycles |
1.00 |
ML-KEM-512 decaps |
346406 cycles |
346326 cycles |
1.00 |
ML-KEM-768 keypair |
374348 cycles |
374216 cycles |
1.00 |
ML-KEM-768 encaps |
433877 cycles |
433736 cycles |
1.00 |
ML-KEM-768 decaps |
532770 cycles |
532650 cycles |
1.00 |
ML-KEM-1024 keypair |
554398 cycles |
554463 cycles |
1.00 |
ML-KEM-1024 encaps |
632515 cycles |
632521 cycles |
1.00 |
ML-KEM-1024 decaps |
754467 cycles |
754358 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Arm Cortex-A72 (Raspberry Pi 4) benchmarks
Details
| Benchmark suite | Current: ee52c4e | Previous: 8dba13b | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
52821 cycles |
53196 cycles |
0.99 |
ML-KEM-512 encaps |
60537 cycles |
61239 cycles |
0.99 |
ML-KEM-512 decaps |
77877 cycles |
77578 cycles |
1.00 |
ML-KEM-768 keypair |
89670 cycles |
89929 cycles |
1.00 |
ML-KEM-768 encaps |
97185 cycles |
98860 cycles |
0.98 |
ML-KEM-768 decaps |
121486 cycles |
123436 cycles |
0.98 |
ML-KEM-1024 keypair |
135647 cycles |
134458 cycles |
1.01 |
ML-KEM-1024 encaps |
148998 cycles |
147089 cycles |
1.01 |
ML-KEM-1024 decaps |
180865 cycles |
180649 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Graviton2 (no-opt)
Details
| Benchmark suite | Current: ee52c4e | Previous: 8dba13b | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
59326 cycles |
59431 cycles |
1.00 |
ML-KEM-512 encaps |
68033 cycles |
68011 cycles |
1.00 |
ML-KEM-512 decaps |
86704 cycles |
86649 cycles |
1.00 |
ML-KEM-768 keypair |
98815 cycles |
98924 cycles |
1.00 |
ML-KEM-768 encaps |
110974 cycles |
110402 cycles |
1.01 |
ML-KEM-768 decaps |
134574 cycles |
134811 cycles |
1.00 |
ML-KEM-1024 keypair |
148680 cycles |
148822 cycles |
1.00 |
ML-KEM-1024 encaps |
163724 cycles |
163875 cycles |
1.00 |
ML-KEM-1024 decaps |
195449 cycles |
195498 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Arm Cortex-A76 (Raspberry Pi 5) benchmarks
Details
| Benchmark suite | Current: ee52c4e | Previous: 8dba13b | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
29409 cycles |
29440 cycles |
1.00 |
ML-KEM-512 encaps |
34618 cycles |
34675 cycles |
1.00 |
ML-KEM-512 decaps |
45210 cycles |
45264 cycles |
1.00 |
ML-KEM-768 keypair |
50053 cycles |
50138 cycles |
1.00 |
ML-KEM-768 encaps |
55322 cycles |
55220 cycles |
1.00 |
ML-KEM-768 decaps |
70154 cycles |
70075 cycles |
1.00 |
ML-KEM-1024 keypair |
73076 cycles |
73079 cycles |
1.00 |
ML-KEM-1024 encaps |
81445 cycles |
81517 cycles |
1.00 |
ML-KEM-1024 decaps |
101376 cycles |
101473 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
1de0ae8 to
978b31c
Compare
978b31c to
7cd3fa0
Compare
|
I hope that CBMC 6.9.0 will unblock progress on this one. I will rebase the branch first and see if the proofs complete OK. |
|
Thanks @rod-chapman! But this also needs significant work on the x86_64 backend. |
|
Oh yes... the x86 back-end has to brought into line with the AArch64 and C back-ends to produce tighter bounds on the output of basemul, right? I have re-based and re-running proofs now on the C stuff. |
CBMC Results (ML-KEM-512)
Full Results (191 proofs)
|
CBMC Results (ML-KEM-768)
Full Results (191 proofs)
|
CBMC Results (ML-KEM-1024)
Full Results (191 proofs)
|
|
Update. I am having trouble getting one proof to work - it's polvec_basemul_acc_montgomery_cached_native(). |
9e4db99 to
7f2d2bc
Compare
|
C Proofs are OK now. I found a Z3 tactic that was effective. @dkostic The next move is to prove that the bounds on the outputs of the AArch64 native implementation of The critical contract is We need to know that's true for the assembly language versions (3 times for K=2,3,4), so that means amending the HOL-Light proof to explicitly state that post-condition. For K=2, that's here or thereabouts: Does that make sense? |
085d1f0 to
999f564
Compare
999f564 to
0495fe6
Compare
457c655 to
bc59d2d
Compare
|
Before and after performance measured on m8i EC2 instance with Intel(R) Xeon(R) 6975P-C: |
4b8afa5 to
0968708
Compare
Tighten the base-multiplication output bounds across the CBMC and HOL Light proofs by constraining the second operand and its multiplication cache. AArch64: - HOL Light: prove output bounds for poly_basemul_acc_montgomery_cached k2/k3/k4 under |b| < 8*MLKEM_Q and |b_cache| < MLKEM_Q, giving abs(r) <= 8323 / 11652 / 14981 respectively (previously the looser 9857 / 13953 / 18049 under unconstrained b/b_cache). - Add matching CBMC input/output bound contracts to the basemul declarations. x86_64: - Append a Barrett-reduction sweep to the AVX2 basemul kernels so every output coefficient is bounded by abs(r) < 2*MLKEM_Q regardless of k (previously grew to ~8*Q at k=4). - HOL Light: update the basemul proofs for the Barrett reduction (refresh bytecode, fold barred_x86, hoist input bound assumptions) and strengthen the postconditions with abs(r) <= 6657. - Add matching input/output bound CBMC contracts. Also includes the earlier CBMC base-multiplication bound refinements and the cassert()->mlk_assert() correction. Signed-off-by: Dusan Kostic <dkostic@amazon.com>
0968708 to
2984fbe
Compare
oqs-bot
left a comment
There was a problem hiding this comment.
Graviton5
Details
| Benchmark suite | Current: 2984fbe | Previous: 0608277 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
13433 cycles |
13460 cycles |
1.00 |
ML-KEM-512 encaps |
15782 cycles |
15785 cycles |
1.00 |
ML-KEM-512 decaps |
21311 cycles |
21325 cycles |
1.00 |
ML-KEM-768 keypair |
22874 cycles |
22835 cycles |
1.00 |
ML-KEM-768 encaps |
25295 cycles |
25297 cycles |
1.00 |
ML-KEM-768 decaps |
33173 cycles |
33118 cycles |
1.00 |
ML-KEM-1024 keypair |
33290 cycles |
33220 cycles |
1.00 |
ML-KEM-1024 encaps |
36932 cycles |
37031 cycles |
1.00 |
ML-KEM-1024 decaps |
47157 cycles |
47147 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Graviton5 (no-opt)
Details
| Benchmark suite | Current: 2984fbe | Previous: 0608277 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
27345 cycles |
27360 cycles |
1.00 |
ML-KEM-512 encaps |
31709 cycles |
31620 cycles |
1.00 |
ML-KEM-512 decaps |
40426 cycles |
40530 cycles |
1.00 |
ML-KEM-768 keypair |
44011 cycles |
44086 cycles |
1.00 |
ML-KEM-768 encaps |
50696 cycles |
50589 cycles |
1.00 |
ML-KEM-768 decaps |
62149 cycles |
62266 cycles |
1.00 |
ML-KEM-1024 keypair |
68288 cycles |
68264 cycles |
1.00 |
ML-KEM-1024 encaps |
75988 cycles |
76069 cycles |
1.00 |
ML-KEM-1024 decaps |
90665 cycles |
90613 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Previously, the base multiplication would assume that one of its inputs is bound by 4096 in absolute value, but make no assumptions about the other input ("b-input" henceforth) and its mulcache.
This commit refines the bounds slightly, as follows:
With those additional bounds in place, it can be showed that the result of the base multiplication is below INT16_MAX/2 in absolute value. Accordingly, this can be added as a precondition for the inverse NTT.
For the native AVX2 backend, the new output bound for the mulcache forces an explicit zeroization of the mulcache. This is not ideal since the cache is in fact entirely unused, but the performance penalty should be marginal (if the compiler can't eliminate the zeroization in the first place).