test: cover multi-level compaction and deep-level deletes#28
Merged
Conversation
Existing tests only exercised the memtable -> L0 (flush) hop and a single L0 -> L1 compaction; there was no coverage for an entry cascading to L1/L2 through compaction while staying readable, nor for deleting a key whose value lives on a non-memtable level. - BoxEngineCompactionTest (unit): drives BoxEngine.applyCompaction with a Compactor so an entry travels memtable -> L0 -> L1 -> L2 and stays readable via get/head/list/range; verifies LWW when an older version sits on a deep level; and covers a DELETE against a key on a deep level shadowing it across the merged read path and being reconciled away by a bottommost compaction (both the aged-drop and young-keep tombstone cases). - MultiLevelCompactionIT: the same level-hierarchy and deep-delete reconciliation on real BookKeeper + ZooKeeper, followed by GC reclaiming the obsoleted ledgers while surviving data stays intact. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YJbv5czMPv67CgywvtNFA9
✅ S3 compatibility gate passed
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
=========================================
Coverage 83.66% 83.66%
Complexity 677 677
=========================================
Files 161 161
Lines 8876 8876
Branches 1330 1330
=========================================
Hits 7426 7426
Misses 970 970
Partials 480 480 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing tests only exercised the memtable -> L0 (flush) hop and a single
L0 -> L1 compaction; there was no coverage for an entry cascading to L1/L2
through compaction while staying readable, nor for deleting a key whose
value lives on a non-memtable level.
Compactor so an entry travels memtable -> L0 -> L1 -> L2 and stays
readable via get/head/list/range; verifies LWW when an older version sits
on a deep level; and covers a DELETE against a key on a deep level
shadowing it across the merged read path and being reconciled away by a
bottommost compaction (both the aged-drop and young-keep tombstone cases).
reconciliation on real BookKeeper + ZooKeeper, followed by GC reclaiming
the obsoleted ledgers while surviving data stays intact.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01YJbv5czMPv67CgywvtNFA9