refactor: split tracking domain logic from segment client#174
Merged
angeloashmore merged 3 commits intomainfrom May 5, 2026
Merged
refactor: split tracking domain logic from segment client#174angeloashmore merged 3 commits intomainfrom
angeloashmore merged 3 commits intomainfrom
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5d82a30. Configure here.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Stamp userId on track events when missing, attach repository groupId on command-start, and treat missing .prismicrc files as telemetry-enabled instead of crashing the telemetry check. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves:
Description
Moves Prismic-specific tracking logic out of
src/lib/segment.tsinto a newsrc/tracking.tsmodule, keepinglib/segment.tsdomain-agnostic. The Segment write key is now derived from the Prismic host rather thanPRISMIC_ENV.Checklist
Preview
How to QA 1
Note
Medium Risk
Changes how CLI telemetry is initialized and how the Segment write key is selected (now based on
hostand.prismicrc), which could impact event delivery/opt-out behavior. Runtime risk is mostly limited to analytics but touches the CLI entrypoint and exit-flush flow.Overview
Telemetry refactor: Moves Prismic-specific tracking concerns (telemetry opt-out via
.prismicrc, repository grouping, command start/end properties, and user identity) into a newsrc/tracking.ts, leavingsrc/lib/segment.tsas a domain-agnostic event queue + sender.Initialization changes: CLI startup (
src/index.ts) andsyncnow callinitTracking/trackCommandStart/trackCommandEnd/trackUserinstead oflib/segmenthelpers, and the Segment write key is determined from the resolved Prismichost(prod vs non-prod) and passed through the subprocess payload tosendSegmentEvents.Reviewed by Cursor Bugbot for commit 23fc651. Bugbot is set up for automated code reviews on this repo. Configure here.
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩