Update Rust examples - #232
Merged
Merged
Conversation
Rust examples now matches new Glfw and create_surface API
catilac
requested changes
Sep 17, 2026
catilac
left a comment
catilac
left a comment
Contributor
There was a problem hiding this comment.
Sorry I approved before running the build. Would you be able to check the results and make the appropriate changes? I will go and do it myself in a day or so. I see that the linux code paths need to be covered as well.
catilac
approved these changes
Sep 17, 2026
catilac
left a comment
catilac
left a comment
Contributor
There was a problem hiding this comment.
actually approving. I'll take care of linux. thanks so much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust examples now matches new Glfw and create_surface API
Please note i haven't manually tested all the examples, only a few of them, but my regexs should have caught every previous 2-params calls for
GlfwContext::new()andglfw_ctx.create_surface().