Skip to content

fix: AutoComplete hinter should link to p5js.org for v2, and v1.p5js.org - #4234

Open
ksen0 wants to merge 2 commits into
developfrom
ksen0-patch-4
Open

fix: AutoComplete hinter should link to p5js.org for v2, and v1.p5js.org#4234
ksen0 wants to merge 2 commits into
developfrom
ksen0-patch-4

Conversation

@ksen0

@ksen0 ksen0 commented Jul 31, 2026

Copy link
Copy Markdown
Member

Fixes #4233

Demo:

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • has no typecheck errors (npm run typecheck)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
  • meets the standards outlined in the accessibility guidelines

@ksen0 ksen0 changed the title Update index.jsx fix: AutoComplete hinter should link to p5js.org for v2, and v1.p5js.org Jul 31, 2026
@ksen0

ksen0 commented Jul 31, 2026

Copy link
Copy Markdown
Member Author

Hi @raclim @doradocodes , fixing this problem is a prereq for making the hinter default! Also tagging @skyash-dev - if this PR is incomplete, and you'd like to make an alternative PR, please feel free. In that case I can close this one, I haven't tested it. The issue came up when we were doing the v2 default switch on the editor and I made the PR mainly as a reminder.

@skyash-dev

skyash-dev commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@ksen0 as i can see the update-p5-hinter file was already updated here

and the changes to index file looks good to me. i can test this once i reach home (afk rn)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AutoComplete hinter should link to p5js.org for v2, and v1.p5js.org

2 participants