fix: AutoComplete hinter should link to p5js.org for v2, and v1.p5js.org - #4234
Open
ksen0 wants to merge 2 commits into
Open
fix: AutoComplete hinter should link to p5js.org for v2, and v1.p5js.org#4234ksen0 wants to merge 2 commits into
ksen0 wants to merge 2 commits into
Conversation
Fixes #4233
Member
Author
|
Hi @raclim @doradocodes , fixing this problem is a prereq for making the hinter default! Also tagging @skyash-dev - if this PR is incomplete, and you'd like to make an alternative PR, please feel free. In that case I can close this one, I haven't tested it. The issue came up when we were doing the v2 default switch on the editor and I made the PR mainly as a reminder. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4233
Demo:
Changes:
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123