Skip to content

Fix/issue 8924 #9009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
solowiz398 wants to merge 6 commits into
base: main
Choose a base branch
from
+7 −1
Open

Fix/issue 8924 #9009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4691d14
test(Vector): add test for setting x dimension for 1d Vector
solowiz398 Jul 21, 2026
a2959ec
fix(Vector): resolve setting x dimension for 1d Vectors
solowiz398 Jul 21, 2026
4e2435f
Merge branch 'main' into fix/issue-8924
solowiz398 Jul 23, 2026
27e711b
Merge branch 'main' into fix/issue-8924
solowiz398 Jul 27, 2026
7bd0cdd
Update test assertions in p5.Vector.js
solowiz398 Jul 27, 2026
a73d756
Merge branch 'main' into fix/issue-8924
solowiz398 Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/math/p5.Vector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ class Vector {
* @param {Number} xVal - The new value for the x component.
*/
set x(xVal) {
if (this.values.length > 1) {
if (this.values.length > 0) {
this.values[0] = xVal;
}
}
Expand Down
6 changes: 6 additions & 0 deletions test/unit/math/p5.Vector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2184,6 +2184,12 @@ suite('p5.Vector', function () {
v = new Vector(1, 2, 3, 4);
expect(v.toString()).toBe('vector[1, 2, 3, 4]');
});

test('should show a value change for x with toString() for 1d Vector', function(){
v = new Vector(1);
v.x = 2;
expect(v.toString()).toBe('vector[2]');
})
});

describe('set heading', () => {
Expand Down