Conversation
…gister in src/app.js
Continuous ReleaseCDN linkPublished PackagesCommit hash: f70fbb2 Previous deploymentsThis is an automated message. |
Member
Author
|
It looks like stacked PRs aren't working cleanly in this setup since feat/svg-integration exists only in my fork. I'll keep this PR as-is for now and clean up the branch history/diff once the existing SVG integration PR is merged. |
VANSH3104
marked this pull request as draft
September 16, 2026 08:59
Member
Author
|
I’ve added these tests to the #9123. There’s no need for this PR now, so I’m closing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #4630
Changes
Adds a comprehensive unit test suite for the native
p5.svgfeature module undertest/unit/svg/.test/unit/svg/svg_recorder.js: TestsShapeRecorderAST node construction (ScopeNode,ShapeNode,BackgroundNode,ImageNode, andClearNode), scope boundaries, method restoration onstop(), andTransformStackDOMMatrix operations (translate,rotate, andscale).test/unit/svg/svg_export.js: TestsSVGVisitorserialization of p5.js drawing commands to SVG elements (<rect>,<circle>,<ellipse>,<line>,<polygon>, and<path>), color and opacity handling (fill-opacity,stroke-opacity), stroke styling, and nested<g transform="matrix(...)">groups.test/unit/svg/svg_import.js: TestsStyleResolverCSS/attribute precedence and inheritance, display/visibility filtering, element visitors, SVG path parsing (M,L,H,V,C,S,Q,T,A, andZ), scientific notation, and<defs>/<use>symbol reuse.test/unit/svg/p5.svg.js: Tests the public APIs onp5.prototype(createShape,buildShape,createSVG,loadSVG,shape,getSVG, andsaveSVG), canvas replay positioning and alignments (CORNER,CENTER,VIEWBOX), automatic frame export lifecycle hooks (predrawandpostdraw), and FES experimental warning logging.PR Checklist
npm run lintpasses