Conversation
loadModel() accepts a boolean normalize flag as its second argument, and the reference examples use it, but no documented overload listed it. The parameter validator reads the same overloads, so loadModel('model.obj', true) logged a false "Expected string at the second parameter" error. Add the overload to the JSDoc and parameterData.json (matching what npm run docs generates for loadModel).
Fixes processing#9176
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9176
Changes:
loadModel()accepts a booleannormalizeflag as its second argument, and the reference examples use it, but no documented overload listed it. The parameter validator reads the same overloads, soloadModel('model.obj', true)logged a false "Expected string at the second parameter" error.loadModel(path, [normalize], [successCallback], [failureCallback])overload to the JSDoc insrc/webgl/loading.js, and the matching entry todocs/parameterData.json(the same entrynpm run docsgenerates forloadModel).test/unit/core/param_errors.js:loadModel(path, true)andloadModel(path, true, callback)now validate,loadModel(path, '.obj', true)still validates, and a number as the second argument is still rejected.PR Checklist
npm run lintpassesAI disclosure
I have taken help of Claude (Anthropic's AI assistant) for this PR: it traced the false FES error to the missing overload and wrote the JSDoc,
parameterData.jsonchange and the tests. I reviewed all of the changes myself.