docs: update remaining loadSound examples to use async/await - #109
Open
NisargJasani0602 wants to merge 1 commit into
Open
docs: update remaining loadSound examples to use async/await#109NisargJasani0602 wants to merge 1 commit into
NisargJasani0602 wants to merge 1 commit into
Conversation
Panner, Panner3D, Amplitude, and Gain still documented loadSound() being called from preload(), which is stale now that loadSound() uses an async/await pattern (see 86c3bcf). Refs processing#106
ksen0
approved these changes
Jul 31, 2026
ksen0
left a comment
ksen0
left a comment
Member
There was a problem hiding this comment.
Nice, thank you! @ogbabydiesal can you check please if this is alright and review / merge as you see fit? Thanks both!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
async function setup()+await loadSound(...), consistent with SoundFile.js, Reverb.js, and Delay.js.Refs #106
Test plan