Fix web client link: chat.<root> not chat.<full-host>#78
Merged
Conversation
The setup help page hardcoded chat.${DOMAIN}, producing
chat.bbs.profullstack.com — a host the Caddy route never serves. The
The Lounge web IRC client is fronted at ${CHAT_DOMAIN}
(chat.${DOMAIN#*.} = chat.profullstack.com). Use ${CHAT_DOMAIN} so the
"web client" link and label match the actual host.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On
bbs.profullstack.com, the setup help page linked the web client tohttps://chat.bbs.profullstack.com/. That host is never served — the Caddy route for The Lounge web IRC client is fronted at${CHAT_DOMAIN}(defaultchat.${DOMAIN#*.}=chat.profullstack.com).Cause
setup.shhardcodedchat.${DOMAIN}in the help HTML (both thehrefand the visible label), where${DOMAIN}is the full BBS host (bbs.profullstack.com).Fix
Use
${CHAT_DOMAIN}in the help text so the link and label match the host the Caddy route actually serves (setup.sh:37,727).🤖 Generated with Claude Code