Repository navigation
fix(book): CoinPay webhook signature + nested payload so cookbook sales settle - #136
Merged
Merged
Conversation
…yload
CoinPay signs HMAC-SHA256 of "${t}.${rawBody}" and sends t=<unix>,v1=<hex>
in X-CoinPay-Signature; the route compared a bare-body HMAC and refused every
real webhook. The payment is nested under data (top-level id is the event),
so read data.payment_id/status/metadata first. markPaid is idempotent and an
unknown payment id answers 200 no-op. Payment metadata now carries
property: hqtui.com (plus account_id/email when a caller has them).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoinPay webhooks never settled a cookbook sale:
X-CoinPay-Signature: t=<unix>,v1=<hex>with HMAC-SHA256 over${t}.${rawBody}(coinpayportal src/lib/webhooks/service.ts). Now parsed, 300s tolerance, timing-safe.data.id; CoinPay sendsdata.payment_idand the top-level id is the event. NewreadWebhookreads nested first, flat fallback.property: 'hqtui.com'(account_id/email when a caller has them; buyer is anonymous today).bun test apps/web/test: 24 pass.🤖 Generated with Claude Code