Repository navigation
fix(pwa): migration 010 crash-looped app.logicsrc.com (inline SQL comments) - #271
Merged
Merged
Conversation
libsql-pg's convertDdl turns an inline '-- comment' inside CREATE TABLE into a column named "--" (Postgres: column "--" specified more than once), which crash-looped app.logicsrc.com on boot after #269. Comments move above the statement, without semicolons (the migrator splits on them). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ThreatCrush Security Scan67 finding(s) HIGH/CRITICAL: 6 | MEDIUM: 29 | LOW: 32
…and 17 more. Full results in the Security tab. Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libsql-pg convertDdl turns an inline
-- commentinside CREATE TABLE into a column named--. Postgres then fails withcolumn "--" specified more than once, and app.logicsrc.com crash-looped on boot after #269. The comments now sit above the statement, with no semicolons, because the migrator splits on them.Verified: replayed the shim's convertDdl output for the old and new file on the prod DB inside BEGIN/ROLLBACK. The old file reproduces the error and the new one creates the table and index. PWA tests: 108 passed.
🤖 Generated with Claude Code