Repository navigation
Same-show check compares the registrable domain (0.3.2) - #72
Merged
Merged
Conversation
…0.3.2) rss.libsyn.com and libsyn.com are one host for a show, so a feed submitted under another subdomain of the same platform was listed a second time as <slug>-2. sameShow now folds both sides to eTLD+1 with tldts (private suffixes kept apart, so alice.github.io and bob.github.io never match). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same-show check matched title + exact host. The dump stores the registrable domain (
libsyn.com), a submitted feed keeps its full host (rss.libsyn.com), so the same show was listed again as<slug>-2(history-shorts-2, top-floor-2, rpgbot-podcast-2 ...).src/lib/domain.ts:registrableDomain()viatldts(public-suffix aware; private suffixes like github.io keep owners apart).sameShowmatcheslower(title)andhost = d OR host LIKE '%.d'for each registrable domain of the feed and site hosts. ~125 ms on prod, same shape as before.test/domain.test.mjs;bun test81 pass,tscclean.🤖 Generated with Claude Code