Repository navigation
Desktop: Sign in with your browser + Open in app from readm3.com (v0.15.0) - #39
Merged
Merged
Conversation
…v0.15.0) The desktop window has no password manager, and an emailed sign-in link opens in the browser, so signing in inside the app did not work. The Account page in the app now offers Sign in with your browser: OAuth (new readm3-desktop client, loopback redirect, PKCE) in the system browser, then POST /oauth/desktop-session trades that token once for a session cookie set in the app's window. Only desktop-client tokens are accepted. readm3.com/viewer gets Open in app: a readm3://open?url=<this page> link the app now registers (electron-builder protocols, installer desktop entry %U + xdg-mime); links off readm3.com are ignored. Falls back to Get the app when nothing answers; hidden on phones and inside the app. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes signing in to the desktop app (no password manager in the window; email links open in the browser): Sign in with your browser via OAuth loopback + one-time
POST /oauth/desktop-session. Adds Open in app on /viewer viareadm3://open?url=….Verified: real Electron app against a local readm3 with a stand-in browser (signed in as the test user; readm3:// opens the page; off-site links ignored); server test for the exchange (desktop token works once, CLI token refused); typecheck, 182 unit, 66 server, 35 site tests; toolbar screenshots at 1280 and 390.
🤖 Generated with Claude Code