Repository navigation
Desktop files read from disk open and sync after a restart; no more "open the folder again" (v0.26.2) - #70
Merged
Merged
Conversation
…open the folder again" (v0.26.2) Anthony: "syncing still broken: That stored file chunk is not here. i get this a lot now. and it says to re-open the folder, why do we have to do that?" Large files, PDFs and images the desktop app reads from disk had a reader for one session only. #66 restored the disk handles after a restart but not these readers, so after relaunching the desktop could not open them ("Open its folder again"), sync could not upload them, and the account held references with no bytes: the web editor's "That stored file chunk is not here". - Every stored file with a restored disk handle gets its reader back on launch and after each sync, so it opens and the next sync uploads what the account lacks. - A file changed on disk to another size is skipped for that upload instead of stopping the whole pass on the server's chunk-size check. - A stored file the account does not hold yet says so in words; "open the folder" is left only for a file that moved or was deleted on disk. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anthony: "That stored file chunk is not here. i get this a lot now. and it says to re-open the folder, why do we have to do that?"
Cause: large files, PDFs and images the desktop reads from disk had a session-only reader (
blobs.fromDisk). #66 restored the disk handles after a restart but not these readers, so after relaunch the desktop couldn't open them, sync couldn't upload them, and the web got 404 "That stored file chunk is not here".reattachDisk()on launch and after each sync applies: every stored file with a restored handle gets its reader back, so it opens and the next sync uploads what the account lacks.New e2e: PDF from the fake desktop disk opens after a restart (fails on main, passes here). Site e2e 48, accounts 6, unit 228, server 106.
🤖 Generated with Claude Code