Skip to content

Sharing an image or PDF read from disk shares the file, not an empty one (v0.26.3) - #73

Closed
ralyodio wants to merge 1 commit into
mainfrom
fix/share-stored-files
Closed

ralyodio wants to merge 1 commit into
mainfrom
fix/share-stored-files

Conversation

@ralyodio

Copy link
Copy Markdown
Contributor

Anthony: "this public shared image is broken". The shared doc's source was "": stored files have an empty source in the editor and Share/Paste link sent it as-is.

  • sharedSource(): Share and Paste link read a stored file's bytes (base64 for binaries).
  • Document source cap 1 MB → 8 MB (6 MB image/PDF); 9 MB body only on document routes.
  • Too large → clear message, never an empty share.

New e2e: desktop disk PNG → Share → document source is the PNG. Site e2e 49, server 106, unit 228.

🤖 Generated with Claude Code

…one (v0.26.3)

Anthony: "this public shared image is broken: readm3.com/s/UXBN…". The share
held an empty source: a stored file (large, or a PDF or image the desktop app reads
from disk) has an empty source in the editor, and Share and Paste link sent it as
it was. Both now send the file's bytes (base64 for a binary), and a shared document
holds up to 8 MB of source (a 6 MB image or PDF) on the document routes only; a
larger file is refused with a message, never shared empty.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ralyodio

Copy link
Copy Markdown
Contributor Author

Superseded by #72, which fixed the same empty-share bug in parallel (and validates base64 per type).

@ralyodio ralyodio closed this Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant