Repository navigation
Publish the Gentoo overlay, and stop winget pointing at a missing file - #119
Merged
Merged
Conversation
…oes not exist
Gentoo turns out not to need anyone's review. An overlay is a git repo laid out
the way portage expects, so it is ours to push like the tap and the bucket, not a
pull request into someone else's tree. profullstack/gentoo-tronbrowser now exists
with net-misc/tronbrowser-bin 3.15.1, and carries its own write deploy key
(GENTOO_OVERLAY_SSH_KEY). It is a complete overlay: metadata/layout.conf and
profiles/repo_name included, both of which gentoo-pairux is missing, so portage
can actually consume this one.
The ebuild is entirely ${PV}/${P}, so a release needs no edits to its contents --
only the filename carries the version. The templater renames it and drops the
stale one, instead of printing a note and leaving tronbrowser-bin-0.1.1.ebuild in
the tree forever. The Manifest is generated: portage wants BLAKE2B and SHA512
next to the byte count rather than the sha256 every other channel uses, and
node's blake2b512 is byte-identical to b2sum. It names the tarball by the
${P}.tar.gz that SRC_URI renames it to, not by the release asset's filename.
winget is a different story and the blocker is the artifact, not the manifest.
tronbrowser-win-x64.zip contains no tronbrowser.exe at all: the Windows entry
point is tronbrowser.cmd, a shim that hunts for Python 3.9+ and then drives a
copy of Ungoogled Chromium the user must install separately. A portable winget
package around that would install for somebody and then fail to start, so it
would be rejected on review or, worse, accepted and broken. The manifest pointed
RelativeFilePath at that non-existent exe; corrected to the file that does exist,
with the real blocker written down. PairUX ships a nullsoft .exe and is in
winget-pkgs today, which is the shape to copy when someone does the Windows build.
Verified against the live overlay: running the submitter for real reports
"already current, nothing to push", which is only true because the generated
Manifest matches the one computed by hand with b2sum and sha512sum byte for byte.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
ThreatCrush Security Scan52 finding(s) HIGH/CRITICAL: 3 | MEDIUM: 28 | LOW: 21
…and 2 more. Full results in the Security tab. Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gentoo is ours, not a review queue
An overlay is just a repo laid out the way portage expects, so Gentoo is pushable like the tap and the bucket rather than a pull request into someone else's tree. profullstack/gentoo-tronbrowser now exists with
net-misc/tronbrowser-bin3.15.1 and its own write deploy key (GENTOO_OVERLAY_SSH_KEY).It is a complete overlay —
metadata/layout.confandprofiles/repo_nameincluded, both of whichgentoo-pairuxis missing, so portage can actually consume this one.The ebuild is entirely
${PV}/${P}, so a release needs no edits to its contents — only the filename carries the version. The templater now renames it and drops the stale one, instead of printing a note and leavingtronbrowser-bin-0.1.1.ebuildthere forever. The Manifest is generated: portage wants BLAKE2B and SHA512 beside the byte count rather than the sha256 every other channel uses, and node'sblake2b512is byte-identical tob2sum. It names the tarball by the${P}.tar.gzthatSRC_URIrenames it to, not by the release asset's name.winget is blocked by the artifact, not the manifest
tronbrowser-win-x64.zipcontains notronbrowser.exe. The Windows entry point istronbrowser.cmd, a shim that hunts for Python 3.9+ and then drives a copy of Ungoogled Chromium the user has to install separately. A portable winget package around that would install for someone and then fail to start — rejected on review, or worse, accepted and broken.The manifest pointed
RelativeFilePathat that non-existent exe. Corrected to the file that does exist, with the real blocker written down. PairUX ships a nullsoft.exeand is in winget-pkgs today, which is the shape to copy when someone does the Windows build.Verified
Running the gentoo submitter for real against the live overlay reports
already current, nothing to push— only true because the generated Manifest matches the one computed by hand withb2sum/sha512sumbyte for byte.🤖 Generated with Claude Code