Skip to content

fix: add timeout to API health check to prevent UI startup hang #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsteude merged 3 commits into from
May 26, 2026
Merged

fix: add timeout to API health check to prevent UI startup hang #441

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37dc428
fix: add timeout to API health check to prevent UI startup hang
hsteude May 26, 2026
9ba7c41
fix: clarify API startup timeout message
hsteude May 26, 2026
3a2141f
fix: clarify API health check retries
hsteude May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docker/kubeflow/start-server.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,12 @@ API_PID=$!
# Wait for API to be ready
echo "Waiting for API server to start..."
for i in {1..30}; do
if curl -s http://127.0.0.1:4096/health > /dev/null 2>&1; then
if curl -sf --max-time 2 http://127.0.0.1:4096/session/status > /dev/null 2>&1; then
echo "API server is ready!"
break
fi
if [ $i -eq 30 ]; then
echo "ERROR: API server failed to start within 30 seconds"
echo "ERROR: API server failed to start after 30 attempts with a 2s request timeout"
exit 1
fi
sleep 1
Expand Down