Fix escaping for non-string label values - #792
Open
Hashim1999164 wants to merge 1 commit into
Open
Conversation
cjihrig
reviewed
Jul 31, 2026
| return str; | ||
| } | ||
| return escapeString(str).replace(/"/g, '\\"'); | ||
| return escapeString(`${str}`).replace(/"/g, '\\"'); |
Contributor
There was a problem hiding this comment.
I think this will still throw for Symbol values. I'm not sure if it's worth trying to handle those or not.
Author
|
Updated |
Hashim1999164
force-pushed
the
fix/escape-non-string-label-values
branch
from
July 31, 2026 19:11
ab68655 to
dcd68f6
Compare
Coerce label values with String() before escape so quotes and newlines in array (and other non-string) values cannot break Prometheus text format, and Symbol values do not throw. Signed-off-by: Hashim Khan <sardarhashim30@gmail.com>
Hashim1999164
force-pushed
the
fix/escape-non-string-label-values
branch
from
July 31, 2026 19:11
dcd68f6 to
e9a077c
Compare
Author
|
Updated to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
escapeLabelValueand were stringified only during template interpolation, so quotes and newlines could break Prometheus text format.`${str}`beforeescapeString/ quote escaping, matching how string labels are already handled.Fixes #791
Test plan
npx jest test/registerTest.js -t "should escape"promtool check metrics