Skip mark_process_dead when the multiprocess path is unset - #1205
Open
Hashim1999164 wants to merge 1 commit into
Open
Skip mark_process_dead when the multiprocess path is unset#1205Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
django_q and similar callers invoke this even when PROMETHEUS_MULTIPROC_DIR is missing. Return instead of passing None into os.path.join. Signed-off-by: Hashim1999164 <64767361+Hashim1999164@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes : #1061
mark_process_dead looked up PROMETHEUS_MULTIPROC_DIR and then passed None into os.path.join, which raises TypeError. Callers such as django_q invoke it even when multiprocess mode is off. Return immediately when no path is set.
Test plan:
@csmarchbanks