Skip to content

Skip the parser benchmark when pytest-benchmark is incompatible #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rbizos wants to merge 1 commit into from
Closed

Skip the parser benchmark when pytest-benchmark is incompatible #1245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions tests/test_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
import importlib.metadata
import importlib.util
import math
import unittest

import pytest

from prometheus_client.core import (
CollectorRegistry, CounterMetricFamily, GaugeMetricFamily,
HistogramMetricFamily, Metric, Sample, SummaryMetricFamily,
Expand Down Expand Up @@ -378,7 +381,20 @@ def collect(self):

HAS_BENCHMARK = importlib.util.find_spec("pytest_benchmark") is not None


def _benchmark_compatible_with_pytest():
# pytest-benchmark 5.3.0 and older read Node._nodeid, which pytest 9.2
# removed: https://github.com/ionelmc/pytest-benchmark/issues/321
from _pytest.nodes import Node
from packaging.version import Version
if hasattr(Node, '_nodeid'):
return True
return Version(importlib.metadata.version('pytest-benchmark')) > Version('5.3.0')


if HAS_BENCHMARK:
@pytest.mark.skipif(not _benchmark_compatible_with_pytest(),
reason='pytest-benchmark is not compatible with this pytest version')
def test_benchmark_text_string_to_metric_families(benchmark):
text = """# HELP go_gc_duration_seconds A summary of the GC invocation durations.
# TYPE go_gc_duration_seconds summary
Expand Down
Loading