feat(encoding): Expose encode_descriptor and encode_metric#299
Open
patrick-ogrady wants to merge 1 commit intoprometheus:masterfrom
Open
feat(encoding): Expose encode_descriptor and encode_metric#299patrick-ogrady wants to merge 1 commit intoprometheus:masterfrom
encode_descriptor and encode_metric#299patrick-ogrady wants to merge 1 commit intoprometheus:masterfrom
Conversation
Signed-off-by: Patrick O'Grady <me@patrickogrady.xyz>
patrick-ogrady
force-pushed
the
expose-encoders
branch
from
a77924b to
0dcb4a7
Compare
patrick-ogrady
commented
Apr 27, 2026
| name, | ||
| unit, | ||
| const_labels, | ||
| family_labels: None, |
Author
There was a problem hiding this comment.
I think we could expose both prefix/family_labels here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For callers implementing their own
Registry(commonwarexyz/monorepo#3664), exposing access to moreencode_*primitives (likeencode_eof) avoids some hairy workarounds downstream.