Skip to content

CI lint fails due to unpinned golangci-lint version #38

Closed

Description

@mickamy

The lint job fails on every push and PR (e.g. #37 and the v0.4.0 tag) with 143 issues, even though the code that triggers them has not changed since main was last green (bf8dc7f, 2026-07-07).

Cause

  • golangci/golangci-lint-action@v9 installs latest (currently v2.15.0) because no version is set
  • .golangci.yaml uses linters.default: all, so linters and checks added in newer golangci-lint releases are enabled automatically

Running golangci-lint v2.15.0 locally against main reproduces the same 143 issues.

Breakdown

Linter Count Notes
exhaustruct_v5 138 New variant of exhaustruct, which is already disabled. Same situation as wsl / wsl_v5.
errcheck 2 <-errCh in proxy/mysql/conn.go:317 and proxy/postgres/conn.go:114
modernize (errorsastype) 2 errors.As → errors.AsType[*net.OpError] in proxy/mysql/conn.go:757 and proxy/postgres/conn.go:556
nolintlint 1 Unused //nolint:paralleltest in config/config_test.go:119

Proposal

  • Disable exhaustruct_v5 alongside exhaustruct
  • Fix the remaining 5 issues
  • Pin the golangci-lint version in ci.yml so new releases don't break CI unexpectedly, and bump it deliberately

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions