Skip to content

feat: add Atlas — the architecture map lives in the repo - #7

Merged
mabry1985 merged 3 commits into
mainfrom
feat/atlas
Oct 16, 2026
Merged

mabry1985 merged 3 commits into
mainfrom
feat/atlas

Conversation

@mabry1985

Copy link
Copy Markdown
Member

What

Adds the Atlas plugin to the Engineer archetype. The architecture model lives in the repo (architecture/*.c4, committed and reviewed with the code).

  • Member (one line, so check_bundle_updates.py can rewrite it): - { id: atlas, url: https://github.com/protoLabsAI/atlas-plugin, ref: v0.1.0 } + comment; atlas added to enabled:.
  • Recommended config.atlas.model_dir: architecture (the default, stated explicitly with the in-repo convention).
  • Description + README: what Atlas adds (drill-down map, code links open the console code pane, presenter tours), how the navigator uses it (existing model = onboarding overview; otherwise offers — asks first — to write one; tours one slide per turn; Mermaid stays for one-offs and when Atlas is off), Node ≥ 20 (PATH or protoAgent's managed runtime, one-click setup banner).
  • CORE FLOOR 0.180.0 → 0.182.0 (atlas min_protoagent_version). The Atlas-aware persona/repo-onboard ships with core feat(engineer): adopt Atlas for the persistent architecture map protoAgent#4242; on a core without it Atlas still loads and works by hand, onboarding just draws the Mermaid overview.
  • requires_tools comment: atlas tools are optional (graceful fallback), so still no contract.

Version: this repo has no version: field and no release workflow — releases are hand-cut tags (latest v0.1.3). A new member suggests v0.2.0 after merge; no release triggered here.

Verify

scripts/verify_bundle.py against the #4242 worktree:

installed atlas@717e500b63 (ref v0.1.0)
loaded atlas: 3 tool(s)
view atlas '/plugins/atlas/view' -> 200
OK — 3 member(s) installed+loaded, all declared views serve 200, contract [] bound.

🤖 Generated with Claude Code

mabry1985 and others added 2 commits October 15, 2026 14:31
Adds the atlas member (atlas-plugin v0.1.0) and enables it: a drill-down
LikeC4 architecture map from the repo's architecture/ folder, committed with
the code, with presenter tours. The navigator uses an existing model as the
onboarding overview and offers (asking first) to write one. Needs Node >= 20
(PATH or the managed runtime). Core floor raised to 0.182.0 (atlas's
min_protoagent_version); the Atlas-aware persona ships with protoAgent #4242.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@protoreview protoreview Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA panel review — PASS

code-review · head 3bd8cb0c5852 · formal

PR #7 is clean. The review panel surfaced no findings across all lanes, and the verifier confirmed there was nothing to verify. No defects, no disagreements, no coverage gaps to flag.

No findings — the review came back clean.

findings JSON (machine-readable)
[]

@protoreview protoreview Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Promoting the PASS verdict for head 3bd8cb0c5852: all checks terminal-green, zero unresolved review threads. (approve-on-green)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@protoreview protoreview Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA panel review — WARN

code-review · head 519a18820dfb · formal

Low-risk change overall: adding a new bundle member (Atlas) with a version bump. The one thing to fix before merge is the unverified pin — the PR verified against v0.1.0 but ships v0.2.0, and the file's own lifecycle comment mandates verification per pin set. The version-field convention slip (bumping in a feature PR rather than a release PR) is real but minor and was explicitly acknowledged by the author; it won't block but should be corrected or reverted. The panel agreed on both findings; verification confirmed both with no disputes. No coverage gaps: the diff is small and fully covered.

Findings

Severity Location Finding Verified
🟠 major protoagent.bundle.yaml:99 The atlas pin was bumped to v0.2.0 after verification was run against v0.1.0, so the shipped pin is unverified and may fail to install or load. ⚠️ uncertain
🟡 minor protoagent.bundle.yaml:73 The bundle's version: is bumped 0.1.3 → 0.2.0 in this feature PR, but the repo's documented convention (the manifest's own comment and .github/workflows/rele… confirmed
findings JSON (machine-readable)
[
  {
    "file": "protoagent.bundle.yaml",
    "line": 99,
    "severity": "major",
    "category": "correctness",
    "claim": "The atlas pin was bumped to v0.2.0 after verification was run against v0.1.0, so the shipped pin is unverified and may fail to install or load.",
    "evidence": "PR description Verify section: `installed atlas@717e500b63 (ref v0.1.0)` \u2014 but the diff pins `ref: v0.2.0`. The file's own PIN LIFECYCLE comment states: 'the verify workflow proves each pin set.'",
    "verdict": "uncertain",
    "note": "PR description Verify section confirms verification ran against v0.1.0; commit 3 (519a188) bumps ref to v0.2.0 with no re-verification recorded; the file's own comment mandates verification per pin set. \u2014 evidence not found at the reviewed head \u2014 downgraded to uncertain, cannot gate a merge (issue #25)",
    "ungrounded": true
  },
  {
    "file": "protoagent.bundle.yaml",
    "line": 73,
    "severity": "minor",
    "category": "conventions",
    "claim": "The bundle's `version:` is bumped 0.1.3 \u2192 0.2.0 in this feature PR, but the repo's documented convention (the manifest's own comment and .github/workflows/release.yml) is to bump it in the release PR merged as `chore: release vX.Y.Z`; the PR is titled 'feat: add Atlas' and its description says 'no release triggered here', so no v0.2.0 tag will be cut and the version field now leads the last cut tag (v0.1.3).",
    "evidence": "Diff: `-version: 0.1.3` / `+version: 0.2.0` sits directly under the comment `# Bump it in the PR that ships the release, then merge as `chore: release vX.Y.Z` (or` / `# run the Release workflow by hand).`; release.yml fires only on `startsWith(github.event.head_commit.message, 'chore: release v')`, and the PR description states 'A new member suggests v0.2.0 after merge; no release triggered here.'",
    "verdict": "confirmed",
    "note": "All cited evidence verified in the diff and release.yml: the comment, the workflow trigger condition, and the PR title/description all confirm the version bump violates the documented release-PR convention.",
    "line_original": 74,
    "line_corrected": true
  }
]

1 finding(s) downgraded to uncertain: the code they quote as evidence does not appear in the file at the reviewed head, nor in this PR's patch for it. A finding that cannot be grounded does not gate a merge (issue #25) — it still stands for a human to judge.

  • protoagent.bundle.yaml (major) — quoted evidence not found at this head: installed atlas@717e500b63 (ref v0.1.0)

@protoreview protoreview Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Promoting the WARN verdict for head 519a18820dfb: all checks terminal-green, zero unresolved review threads. (approve-on-green)

Open findings carried by this approval — non-blocking, but they did not go away:

  • major protoagent.bundle.yaml:99 — The atlas pin was bumped to v0.2.0 after verification was run against v0.1.0, so the shipped pin is unverified and may fail to install or load.
  • minor protoagent.bundle.yaml:73 — The bundle's version: is bumped 0.1.3 → 0.2.0 in this feature PR, but the repo's documented convention (the manifest's own comment and .github/workflows/release.yml) is to bump it in the release PR

Approving a WARN does not resolve its findings (issue #22).

@mabry1985
mabry1985 merged commit 2b8c3f3 into main Oct 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant