Repository navigation
Conversation
There was a problem hiding this comment.
QA panel review — PASS
code-review · head a5a6a36d1553 · formal
PR #34 is a two-line README.md addition (a blank line plus a scratch HTML comment) that the PR itself describes as temporary and auto-closing. The only finding is a nit-level convention violation: the scratch comment lives in a tracked file rather than the gitignored .proto/ directory that PROTO.md §8 prescribes. The verifier confirmed the finding as-is — no panel disagreement, no coverage gaps, no refutations. The fix-first item is trivial (move or delete the comment before merge), but given the PR's stated intent to auto-close, it may be acceptable to let the auto-close handle it.
Findings
| Severity | Location | Finding | Verified | |
|---|---|---|---|---|
| ⚪ | nit | README.md:87 |
A scratch/debug HTML comment is committed to a tracked file (README.md), violating the repo's documented scratch discipline (PROTO.md §8: scratch belongs in gi… | confirmed |
findings JSON (machine-readable)
[
{
"file": "README.md",
"line": 87,
"severity": "nit",
"category": "conventions",
"claim": "A scratch/debug HTML comment is committed to a tracked file (README.md), violating the repo's documented scratch discipline (PROTO.md \u00a78: scratch belongs in gitignored .proto/, never committed). Low-signal: the PR is explicitly temporary and auto-closing, so this is the intended mechanism rather than an oversight.",
"evidence": "<!-- scratch check 2026-09-15T10:10:24Z: safe to close -->",
"verdict": "confirmed",
"note": "Diff shows the comment at line 87 of README.md; PROTO.md \u00a78 ('Agent-scratch') explicitly states '.proto/ is the coding agent's own scratch \u2014 gitignored, never commit.' The scratch comment in a tracked file is a literal violation of that rule."
}
]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary PR for a reviewer check. Will be closed automatically.