Repository navigation
fix(read): a 404 on a file read lists the nearest existing directory - #35
Merged
Merged
Conversation
A bare 404 from github_read_file / github_read_pr_file said "repo not found or not accessible, or the path/ref/number doesn't exist". To a model, that reads as an access problem. The QA panel then guessed sibling paths one call at a time: on protoAgent#3771, 26 of its 120 reads were invented filenames. On a 404, probe up to 4 parent directories at the same ref. If one exists, say the repo and ref are fine and only the path is wrong, and list that directory (capped at 60 entries). If none exists, the repo or ref is the problem, so the classified error stands. A non-404 failure skips the probe. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
QA panel review — PASS
code-review-structural · head 6992b1dd2efa · formal
The panel's brief could not be read from this round's report (no delimited brief block). The findings below are unaffected.
No findings — the review came back clean.
findings JSON (machine-readable)
[]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Langfuse showed a lot of ERROR tool spans on the QA reviewer (Vera). On
protoAgent#3771, 26 of her 120github_read_file/github_read_pr_filecalls failed on paths that don't exist, such asapps/web/src/goals/GoalCreateDialog.tsx,settings/ThemeQuickDialog.tsxanddesign.css. The real file wassettings/ThemeQuickButton.tsx.Every miss returned the same message:
repo '…' not found or not accessible, or the path/ref/number doesn't exist in it. To a model, that reads as an access problem. So the lane guessed another sibling path, one call and one ERROR span at a time.Fix
When a file read gets a 404,
read_tools._missing_path_hintprobes up to 4 parent directories at the same ref. Each probe is a GET, per #29.dir/suffixed). The model can pick the right file in one step.github_read_pr_filestill fails loudly and never falls back to the default branch. The hint only improves the error text.Verification
ruff checkandruff format --checkare clean.gh:ThemeQuickDialog.tsxon #3771 listsapps/web/src/settings(which containsThemeQuickButton.tsx).Rollout
Vera picks this up on her next image bump, which moves
GITHUB_PLUGIN_REFin qaEngineer. Desktop agents get it through a plugin update.🤖 Generated with Claude Code