Repository navigation
feat: Ready gate: spec-width advisory ("consider splitting") beside the file-count breadth cap - #551
Merged
mabry1985 merged 1 commit intoOct 17, 2026
Conversation
…he file-count breadth cap
There was a problem hiding this comment.
QA panel review — PASS
code-review-structural · head 2f1cc8e859c5 · formal
No findings were raised, so there was nothing to verify. The change is purely additive (+269/-0), introducing a spec-width advisory to _ready_findings. All five review angles found no defects. The protoPatch engine was unavailable in this environment; the LLM structural finder covered that lane manually and found nothing. No action required.
No findings — the review came back clean.
findings JSON (machine-readable)
[]
mabry1985
deleted the
feat/bd-fcgu-ready-gate-spec-width-advisory-consider
branch
October 17, 2026 19:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Ready gate's only pre-failure nudge toward smaller slices was the breadth cap, which counts
files_to_modify— so a conceptually wide card with few files (ds-syt / protoContent#609: 4 files, medium, timed out twice at 1800s) slipped through. This adds a non-blockingspec-widthadvisory in_ready_findingsthat reads width out of the spec itself via three tunable signals — spec length overSPEC_WIDTH_MAX_CHARS(2500), acceptance-criteria count overSPEC_WIDTH_MAX_CRITERIA(6, counted with the existing_decompose_acso it matches the requirement ledger), and "and also"-style concern joins overSPEC_WIDTH_MAX_JOINS(3). The message names every signal that tripped with its measured value and threshold, and the fix suggests splitting into one-concern cards.It only ever appends to
advisories(neverrefusals), soready_check(...)["ok"]stays True andmark_readystill promotes a wide-but-valid card. It skips task-type beads and runs before the early return, so a card with no files and nodepends_onis still measured. Because create/update already returnready_check, the advisory surfaces atboard_create_feature/board_update_featureautomatically. New constants live besideMAX_FILES_BY_DIFFICULTY;docs/lifecycle.mddocuments the advisory and its thresholds;changelog.d/548.mdrecords the change.Fixes #548