Repository navigation
feat: Decompose task carries what the timed-out attempt learned (timeout context: elapsed, last tool, thought tail) - #552
Merged
mabry1985 merged 1 commit intoOct 17, 2026
Conversation
…out context: elapsed, last tool, thought tail)
There was a problem hiding this comment.
QA panel review — PASS
code-review-structural · head a76184ddc714 · formal
Low-risk, purely additive change threading a learned context string into the decomposition task spec. The panel raised a single nit (cross-test-file import of private helpers), which the verifier confirmed at head. No blockers, no majors, no disagreements. Verification covered all findings (n=1 annotated, 0 refuted). No coverage gaps.
Findings
| Severity | Location | Finding | Verified | |
|---|---|---|---|---|
| ⚪ | nit | tests/test_decompose_learned_549.py:9 |
Cross-test-file import couples test_decompose_learned_549 to test_timeout_decompose_378's private helpers (_SplitStore, _asking_board, _blocks); renaming or re… | confirmed |
findings JSON (machine-readable)
[
{
"file": "tests/test_decompose_learned_549.py",
"line": 9,
"severity": "nit",
"category": "conventions",
"claim": "Cross-test-file import couples test_decompose_learned_549 to test_timeout_decompose_378's private helpers (_SplitStore, _asking_board, _blocks); renaming or refactoring that file breaks this test with an opaque ImportError.",
"evidence": "from test_timeout_decompose_378 import _SplitStore, _asking_board, _blocks",
"source": "protopatch",
"verdict": "confirmed",
"note": "Line 9 at head a76184dd: `from test_timeout_decompose_378 import _SplitStore, _asking_board, _blocks` \u2014 all three are underscore-prefixed private names in a sibling test module; the coupling claim is accurate."
}
]There was a problem hiding this comment.
Promoting the PASS verdict for head a76184ddc714: all checks terminal-green, zero unresolved review threads. (approve-on-green)
Open findings carried by this approval — non-blocking, but they did not go away:
- nit
tests/test_decompose_learned_549.py:9— Cross-test-file import couples test_decompose_learned_549 to test_timeout_decompose_378's private helpers (_SplitStore, _asking_board, _blocks); renaming or refactoring that file breaks this test with
Approving a WARN does not resolve its findings (issue #22).
mabry1985
deleted the
feat/bd-n6l7-decompose-task-carries-what-the-timed-ou
branch
October 17, 2026 19:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Decomposition tasks now include bounded context from timed-out attempts: elapsed time, last tool, and thought tail, with guidance to isolate the stalled work into its own slice. Empty context preserves the existing task spec, and context collection failures or older store signatures do not prevent parking or decomposition requests.
Added coverage in
tests/test_decompose_learned_549.pyand a changelog entry. Refs #549.