Skip to content

feat: Decompose task carries what the timed-out attempt learned (timeout context: elapsed, last tool, thought tail) - #552

Merged
mabry1985 merged 1 commit into
mainfrom
feat/bd-n6l7-decompose-task-carries-what-the-timed-ou
Oct 17, 2026
Merged

mabry1985 merged 1 commit into
mainfrom
feat/bd-n6l7-decompose-task-carries-what-the-timed-ou

Conversation

@mabry1985

Copy link
Copy Markdown
Member

Summary

Decomposition tasks now include bounded context from timed-out attempts: elapsed time, last tool, and thought tail, with guidance to isolate the stalled work into its own slice. Empty context preserves the existing task spec, and context collection failures or older store signatures do not prevent parking or decomposition requests.

Added coverage in tests/test_decompose_learned_549.py and a changelog entry. Refs #549.

…out context: elapsed, last tool, thought tail)

@protoreview protoreview Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA panel review — PASS

code-review-structural · head a76184ddc714 · formal

Low-risk, purely additive change threading a learned context string into the decomposition task spec. The panel raised a single nit (cross-test-file import of private helpers), which the verifier confirmed at head. No blockers, no majors, no disagreements. Verification covered all findings (n=1 annotated, 0 refuted). No coverage gaps.

Findings

Severity Location Finding Verified
⚪ nit tests/test_decompose_learned_549.py:9 Cross-test-file import couples test_decompose_learned_549 to test_timeout_decompose_378's private helpers (_SplitStore, _asking_board, _blocks); renaming or re… confirmed
findings JSON (machine-readable)
[
  {
    "file": "tests/test_decompose_learned_549.py",
    "line": 9,
    "severity": "nit",
    "category": "conventions",
    "claim": "Cross-test-file import couples test_decompose_learned_549 to test_timeout_decompose_378's private helpers (_SplitStore, _asking_board, _blocks); renaming or refactoring that file breaks this test with an opaque ImportError.",
    "evidence": "from test_timeout_decompose_378 import _SplitStore, _asking_board, _blocks",
    "source": "protopatch",
    "verdict": "confirmed",
    "note": "Line 9 at head a76184dd: `from test_timeout_decompose_378 import _SplitStore, _asking_board, _blocks` \u2014 all three are underscore-prefixed private names in a sibling test module; the coupling claim is accurate."
  }
]

@protoreview protoreview Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Promoting the PASS verdict for head a76184ddc714: all checks terminal-green, zero unresolved review threads. (approve-on-green)

Open findings carried by this approval — non-blocking, but they did not go away:

  • nit tests/test_decompose_learned_549.py:9 — Cross-test-file import couples test_decompose_learned_549 to test_timeout_decompose_378's private helpers (_SplitStore, _asking_board, _blocks); renaming or refactoring that file breaks this test with

Approving a WARN does not resolve its findings (issue #22).

@mabry1985
mabry1985 merged commit 7182e5e into main Oct 17, 2026
7 checks passed
@mabry1985
mabry1985 deleted the feat/bd-n6l7-decompose-task-carries-what-the-timed-ou branch October 17, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant