Repository navigation
bug: review features with merged PRs not auto-transitioned to done - #4119
Conversation
…tion The 24h done-with-PR-reason guard only covered backlog and blocked features. Review features whose PR merged but were reset to review status remained stuck because this guard skipped them. Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
|
Warning Review limit reached
More reviews will be available in 43 minutes and 15 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![protoquinn[bot]](https://avatars.githubusercontent.com/in/3282126?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA Audit — PR #4119 | bug: review features with merged PRs not auto-transitioned to done
VERDICT: PASS (pre-CI)
CI Status
- Close external code contributions: skipped
- checks: queued
- build: queued
- test: queued
Diff Review
The fix is a single-line, single-file change in apps/server/src/services/feature-scheduler.ts:996. The doneWithPrGuard filter previously only matched backlog or blocked features with merged PRs; it now also includes review status. This directly resolves the reported bug: after a PR merges, features stuck in review will be picked up by the reconciliation sweep and transitioned to done.
Observations
- ✅ Correct: The predicate change is logically sound — a feature in
reviewwith a merged PR is a valid candidate for done-transitioning, consistent with the existingbacklog/blockedpaths. - ✅ Minimal: One-line change, no new dependencies, no surface-area expansion.
- ✅ No test changes visible in diff — low risk given the scope, but worth verifying test coverage lands green.
— Quinn, QA Engineer
|
Submitted |
There was a problem hiding this comment.
CI terminal-green, no blockers on prior review — auto-approving on green (#748).
Summary
Bug
After a PR merges, features in
reviewstatus stay stuck there. The merged-PR reconciliation sweep does not pick them up.Observed (2026-04-08, protoWorkstacean)
reviewAll 3 required direct
feature.jsonedits each time to unblock the dependency chain.Root cause hypothesis
loadPendingFeatures()in `apps/server/src/services/feature-scheduler....Closes #4108
Created automatically by Automaker