Repository navigation
deploy(vera): pr-reviewer v0.60.0 → v0.61.0, structural cap 16 → 32 with matching budgets - #120
Conversation
…ith matching budgets - pr-reviewer v0.61.0: every structural gap gets a reason class (no more `?`), and the panel-attempt ceiling is 4200s. - Seed: structural_max_features 32, time_budget_s 3000, finder_timeout_s 3150, panel_attempt_timeout 4050. The sizing arithmetic is in the seed comment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
QA panel review — WARN
code-review-structural · head af53a289bf94 · formal
Low-risk config/version bump (plugin v0.60.0 → v0.61.0, raised panel budgets). No blockers or majors. The single surviving finding is a minor doc-drift: the new comment and README say time_budget_s "was 1500" but the seed's actual prior value was 900. Verification confirmed it as-is; nothing was refuted or re-graded. No panel disagreement, no coverage gaps, no prior requests to disposition.
Findings
| Severity | Location | Finding | Verified | |
|---|---|---|---|---|
| 🟡 | minor | deploy/vera.langgraph-config.yaml:88 |
The new seed comment and the README state time_budget_s 'was 1500' / 'from 1500', but the seed's prior value was 900 — a doc-drift that misstates the value's o… | confirmed |
findings JSON (machine-readable)
[
{
"file": "deploy/vera.langgraph-config.yaml",
"line": 88,
"severity": "minor",
"category": "conventions",
"claim": "The new seed comment and the README state time_budget_s 'was 1500' / 'from 1500', but the seed's prior value was 900 \u2014 a doc-drift that misstates the value's own history. Flagged by both conventions and removed-behavior review.",
"evidence": "New comment: `# time_budget_s 3000 (default 600; was 1500 at cap 16)` and README `time_budget_s: 3000` (from 1500); but the diff removes `- time_budget_s: 900` and the README's prior note says the seed carried `time_budget_s: 900` since 2026-09-26. The sibling comment correctly reads `finder_timeout_s \u2026 Was 2100`, so 1500 is an outlier, not a convention.",
"source": "panel",
"verdict": "confirmed",
"note": "Diff removes `time_budget_s: 900`; new comment says 'was 1500 at cap 16' and README says 'from 1500'. Prior value was 900, not 1500. Sibling `finder_timeout_s` correctly says 'Was 2100' matching the removed `finder_timeout_s: 2100`."
}
]There was a problem hiding this comment.
Promoting the WARN verdict for head af53a289bf94: all checks terminal-green, zero unresolved review threads. (approve-on-green)
Open findings carried by this approval — non-blocking, but they did not go away:
- minor
deploy/vera.langgraph-config.yaml:88— The new seed comment and the README state time_budget_s 'was 1500' / 'from 1500', but the seed's prior value was 900 — a doc-drift that misstates the value's own history. Flagged by both conventions a
Approving a WARN does not resolve its findings (issue #22).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
QA panel review — PASS
code-review-structural · head 21a8080464ee · formal
Clean config-only PR: plugin bump v0.60.0 → v0.61.0 and four budget increases in the seed YAML. No findings were raised, so there was nothing to verify. The round-1 minor doc-drift on time_budget_s (seed comment misstating the prior value as 1500 instead of 900) is resolved in this head — the comment and README now correctly state the prior value. No panel disagreement, no coverage gaps, no verification gaps.
No findings — the review came back clean.
findings JSON (machine-readable)
[]Addressed since the last round (1 minor/nit): deploy/vera.langgraph-config.yaml:88 — no longer raised, and the PR changed the code around them since they were raised.
Bumps the pr-reviewer pin in the three places CI checks agree on (bundle, Dockerfile ARG, README). It also raises Vera's structural feature cap, with the budgets to match.
Why
The health alarm read: structural lane short on 12/54 rounds in 24h.
v0.61.0
no-output:max-turnsandno-output. Both reason-less outages were the relay model, not protoPatch.exit-4:gateway-<status>for a labelled HTTP status, andunclassified(with astructural_detailsnippet) replacesother.Budgets (seed; the live volume is set via
POST /api/configat roll time)structural_max_featurestime_budget_sfinder_timeout_spanel_attempt_timeoutSizing
time_budget_s:structural_jobs4 took ~353s per feature slot at p90 (~239s at p50).The seed was also out of step with the live time budget (900 vs 1500). It now carries the live values.
🤖 Generated with Claude Code