Repository navigation
train_flake: remove its temp dirs on exit; add solo-rerun, AIMD, pin-test, deletion-budget rules - #2098
Merged
Conversation
…test, deletion-budget rules train_flake.sh now cleans up the flake-store and flake-out dirs it creates via an EXIT trap over only its own mktemp paths. Short rules added to red-gate-triage, retrospective and pipeline-optimizer; scripts/test-train-flake-cleanup.sh pins both. Tests: 7/7 (test-train-flake-cleanup.sh), 13/13 (test-fleet-lessons.sh; no-rm pin narrowed to the EXIT trap) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
train_flake.sh now removes the flake-store and flake-out temp dirs it creates (EXIT trap over only its own mktemp paths), on both the triage and
--basepaths, and leaves unrelated TMPDIR entries alone.Doctrine additions, each pinned by the new test:
Verification
bash scripts/test-train-flake-cleanup.sh: 7/7, including a positive control that the triage run actually saw its flake store.Supersedes #2093 and #2096: narrows the no-rm pin in test-fleet-lessons.sh to the EXIT trap (13/13), drops train_flake.sh from the mktemp-trap baseline now that it traps, and regenerates the deep-code-review INDEX left stale on main.
🤖 Generated with Claude Code