Repository navigation
review_checks.sh: add --full whole-repo mode and honour .gitleaksignore - #2102
Closed
remigiusz-antczak wants to merge 1 commit into
Closed
remigiusz-antczak wants to merge 1 commit into
remigiusz-antczak wants to merge 1 commit into
Conversation
--full scans every tracked file against git's empty tree, so users no longer synthesize a base; gitleaks runs once over the working tree (--no-git -s .) and only tracked, non-vendored files are reported. gitleaks now drops fingerprints listed in the repo's .gitleaksignore in diff and full modes, read as of BASE (HEAD under --full) so a change cannot approve its own finding. A missing gitleaks now lands as a not-checked row instead of only a stderr line. perun_policy.py is located from the script's resolved directory. The flag is routed in references/tool-hub.md and the test is wired into scripts/ci-tests.d. Tests: 11/11 (test-review-checks-full.sh); scanner-offline-db 19/19, gitleaks-allow 16/16, gitleaks-template 9/9 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Superseded by the rebased branch land/wave-1028an-r3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
review_checks.shwas diff-only, so a whole-repo audit had to fake a base and gitleaks ignored the project's.gitleaksignore. This adds a--fullmode and makes ignore handling safe.--fullreviews the whole working tree against git's empty tree. gitleaks runs once, batched, over the working tree (--no-git -s .), skippingnode_modules,vendorand.claude/worktrees..gitleaksignoreis honoured only from the base or committed version, passed with--gitleaks-ignore-path. A change cannot whitelist its own leak by editing the working-tree file.--repoand the offline OSV/trivy/XDG cache handling from Scanner offline vuln DB, semgrep writable cache, dev-only severity cap #2097 are unchanged.Verification (run locally on this head)
bash scripts/test-review-checks-full.sh: 11/11 (adds working-tree-ignore, non-ASCII leak, run-failure and diff-mode cases)bash scripts/test-scanner-offline-db.sh: 19/19bash scripts/test-review-checks-gitleaks-allow.sh: 16/16bash scripts/test-review-checks-gitleaks-template.sh: 9/9python3 scripts/skill_index.py --check: okIndependent review: 3 red and 3 yellow findings, all fixed in this commit.
🤖 Generated with Claude Code