Repository navigation
Add opt-in dynamic_probe.py step to the audit flow - #2103
Closed
remigiusz-antczak wants to merge 1 commit into
Closed
remigiusz-antczak wants to merge 1 commit into
remigiusz-antczak wants to merge 1 commit into
Conversation
Static scanners missed an unhandled URIError returning 500, an unrated error endpoint and a DB TLS verify-off setting, and the audit had no dynamic step. dynamic_probe.py probes a local app (localhost or 127.0.0.1 only, redirects never followed) for 5xx on malformed percent-encoding and oversized inputs, missing rate limiting on a named endpoint, missing security headers and open redirect, and prints review_checks-shaped rows (finding, clean or not-checked). Any dropped, reset or timed-out request makes the affected probe not-checked, never clean. Routed from full-audit.md via references/dynamic-probe.md. Tests: ran 32/32 (scripts/test_dynamic_probe_mock.py, mocked connection layer, no socket). Needs CI or an unsandboxed run: 16 checks in scripts/test_dynamic_probe.py (stub http.server on 127.0.0.1); the authoring sandbox blocks bind. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Superseded by land/wave-1028ap-r2 (rebased; full-map row trimmed under the 19000-byte core cap). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an opt-in dynamic step to the full audit. Static scanners missed an unhandled
URIErrorreturning 500, an unrated error endpoint and a DB TLS verify-off setting in a recent audit, and the audit had no dynamic step.dynamic_probe.pyprobes a local app only (localhost or 127.0.0.1; redirects never followed) for:It prints rows in the
review_checks.shshape (finding, clean or not-checked). A dropped, reset or timed-out request makes the affected probe not-checked, never clean. Routed fromfull-audit.mdviareferences/dynamic-probe.md.Verification
python3 scripts/test_dynamic_probe_mock.py: 32/32 locally (mocked connection layer, no socket).scripts/test_dynamic_probe.py(16 checks against a stubhttp.serveron 127.0.0.1) runs in CI only; the authoring sandbox blocks local bind.scripts/ci-tests.d/dynamic-probe.shruns both.skill_index.py --checkand the size ratchet pass locally against the base.🤖 Generated with Claude Code