Repository navigation
Flow guards review fixes: real fitness_tick caller, default baseline checks, narrow wired allowlist, freeze_hook - #2106
Closed
remigiusz-antczak wants to merge 1 commit into
Closed
remigiusz-antczak wants to merge 1 commit into
remigiusz-antczak wants to merge 1 commit into
Conversation
…checks, narrow wired allowlist, freeze_hook, one canonical reference fitness_tick closable needs executable wiring (JSON, CI, .sh, Makefile, loop entry line), not a mention; baseline_guard refuses by default (--force overrides); wired_check ALLOW_RE matches explicit orphan/unused allowlist names, a # orphan: marker and an allowlist: key; freeze_hook.py parses argv and denies git push, gh pr merge and gh api merge calls while frozen (fail closed on malformed input or unreadable state, allow in a non-repo), wired in the operating-layer template and doctor; finding_guard/fitness_tick/flow_alarm doctrine lives once in references/flow-guards.md. Tests: 43/43 (flow_guard_fixes 15, fitness_tick 6, baseline_guard 5, orphan_allowlist_wired 4, freeze_gate 6, skill_index_split 7) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review follow-ups to the flow guards that landed in the peer-lessons batch.
fitness_tick.py closablenow needs executable wiring (JSON hook config, CI,.sh, Makefile or a loop entry line). A prose mention no longer counts as a caller.baseline_guard.pyrefuses a suspect baseline by default;--forceoverrides.wired_check.pyallowlist matching is narrowed to explicit orphan/unused allowlist names, a# orphan:marker and anallowlist:key.freeze_hook.py(PreToolUse) parses argv and deniesgit push,gh pr merge(including-R/--repo) andgh apimerge calls while a freeze is on. It fails closed on malformed input or unreadable state and allows in a non-repo directory. It is wired in the operating-layer template and the doctor.references/flow-guards.md.Verification
skill_index.py --checkand the size ratchet pass against the base.🤖 Generated with Claude Code