Compiling any program after last few PRs breaks program from running

[saildot4k]

Sometime within the last week or two compiling any program breaks the program and it will not start

I use GH actions to compile have tried both containers:
container: ghcr.io/ps2homebrew/ps2homebrew:main
container: ps2dev/ps2dev:latest

Check latest ps2homebrew/wLaunchElf as well...

This is quite annoying and stifling updating:
https://github.com/saildot4k/PlayStation2-Basic-BootLoader-Extended
https://github.com/saildot4k/wLaunchELF_R3Z

I know this is affecting OSDMenu as well as things that used to work drastically do not work, even something simple like launching a disc

Programs neither start in PCSX2 or on bare metal. I think the last PR that fully worked for me was #865, its after this that things drastically went downhill and now to a standstill.

[10522]

@AKuHAK @rickgaiser @israpps @uyjulian @fjtrujy @Wolf3s @362053534 @KrahJohlito @mystyq @NathanNeurotic @saildot4k

OPL 2245 (run_2403) - works well
OPL 2245 (run_2411) - the list of games is not displayed via SMB

After OPL 2241 (run_2351) the controllers as well as MX4SIO and MMCE broke. More details here: 1, 2, 3, 4, 5, 6, 7, 8, 9.

Also starting with OPL 2009 (run_1208) the following games are broken:

Demolition Girl [SLES_534.03]
Dog of Bay [SLPS_200.57]
Fighting Angels [SLES_534.08]
Fitness Fun [SLES_529.83]
Zombie Zone [SLES_533.98]

PS2Net is still broken in wLE and wLE_ISR. More details here.

[saildot4k]

I recompiled the last working versions of my apps: PS2BBLE, WLE_R3Z and MANY MANY things are broken still due to latest ps2sdk changes
Rebooting IOP hangs
UDPFS cannot connect in wLE R3Z
I gave up trying to find more broken after this
#893 may have fixed programs starting, but not working

[fjtrujy]

I recompiled the last working versions of my apps: PS2BBLE, WLE_R3Z and MANY MANY things are broken still due to latest ps2sdk changes Rebooting IOP hangs UDPFS cannot connect in wLE R3Z I gave up trying to find more broken after this #893 may have fixed programs starting, but not working

@uyjulian could you please take a look at these issues?

[saildot4k]

@fjtrujy reopen issue?

[uyjulian]

Open already fixed after #894
Rebooting IOP works fine for me

Having minimal reproducible cases will allow me to isolate the issue faster. I cannot spend hours doing full rebuilds on these large projects because incremental builds are broken
Conflating issues together will lead to more confusion

[saildot4k]

I feel it would be better to revert the last few weeks of breaking changes. IIRC last working ps2sdk PR for me was #872

I really don't feel like spending time tracking down or making reproducable cases as I want to finish these 2 apps and probably leave the scene. If I find time sure, but these breaking changes are very deflating and draining my limited time already. The goal for me was to finish wLE R3Z and then integrate into github.com/ps2homebrew and let others take it away as the "definitive edition"

Id assume same for pcm720 and his FMCB fork which puts FMCB in the coffin.

[uyjulian]

I cannot identify what to revert if I cannot identify the issue

[saildot4k]

Thats why I suggest rolling back to something sane.

[fjtrujy]

Thats why I suggest rolling back to something sane.

Let’s go to identify the current issue better, don’t you have a dummy sample where we can reproducir the issue?

[fjtrujy]

@saildot4k, the "latest" state of the repo we can assume to contain errors. We are doing our best to have it stable, but sometimes we introduce issues, especially if we perform many changes in a recent period.
This is why I was tagging the v2.0.0 version some weeks ago.
https://hub.docker.com/layers/ps2dev/ps2dev/v2.0.0/images/sha256-7e369990274611d9f145cfe60ac578ded5aad5b6485d0afd67c7bfecce830cef

Unfortunately, we don't have automated tests to be executed on each PR to ensure things are working as expected.
This is why I was asking for the smallest possible example, or at least a better description of the symptom you're suffering from, in order to fix it

[saildot4k]

I did choose not to use ps2dev docker image as after the mx4sio/mmce hook changes I could not get that to work as needed, so changing to this container fixed many issues for me: ghcr.io/ps2homebrew/ps2homebrew:main

Sadly what I need is in between v2.0.0 and latest as I needed the new mmce/mx4sio hooks and psx xfrom/dvr fixes..

I do not have a dummy sample but you can try this run:
https://github.com/saildot4k/wLaunchELF_R3Z/actions/runs/28964281694

under MISC/ there is REBOOT IOP which I added because I am not yet done with UDPFS (though it works amazingly well thanks to pcm720 and maximus32) and if it does not connect, you need a IOP reboot and reload driver stack

[uyjulian]

I have reverted #895

[10522]

@AKuHAK @sp193 @israpps @uyjulian @fjtrujy @Wolf3s @KrahJohlito @NathanNeurotic @saildot4k @CosmicScale @pcm720

The developers are writing here that issues with OPL started with this commit, and judging by this report, even this PR didn't fix all issues.

Make PS2SDK Great Again

P.S. Help us, @rickgaiser. You're our only hope.

[fjtrujy]

I have reverted #895

@saildot4k did the problem go away with the PR that was reverted?