Repository navigation
Use the supplied libusb handle for host bulk reads - #77
Merged
Merged
Conversation
Read from the supplied device handle instead of the global handle, keeping transfers associated with the correct connection.
davidgfnet
self-requested a review
October 26, 2026 19:54
davidgfnet
approved these changes
Oct 26, 2026
davidgfnet
left a comment
davidgfnet
left a comment
Member
There was a problem hiding this comment.
Looks good! That was an oopsie there :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Fix a standalone Mac host bug extracted from #72:
euid_usb_bulk_read(dev, ...)previously passed the globalusbhdrtolibusb_bulk_transferrather than using the supplieddevhandle.This one-line correction makes reads use the caller-requested connection. No directory, PSP firmware, or long-uptime recovery code is included.
Verification
make -C usbhostfs_pc -j4on macOS: passed (only the pre-existing unrelatednewpathlenwarning).git diff --check: passed.Split from #72 for independent review and merge.