Repository navigation
ship deslop, control-cli, and control-ui inside pstack - #44
Conversation
copy the three skills from cursor/plugins e73df47 and drop every cursor-team-kit mention. Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>
caelaxie
left a comment
There was a problem hiding this comment.
verdict: changes requested, proof only. content passes.
- the three new skills are byte-identical to cursor/plugins 99b609a
cursor-team-kit/skills/{deslop,control-cli,control-ui}/SKILL.md(blobs 1b3827c, 69289ac, 68484fd match). - the 9 team-kit removals are phrase-only; a grep of every text file at 45aa2af finds no
team-kitleft. Closes #32–#43match the 12 open issues one to one. Validate plugin is green.
missing: devin harness proof on 45aa2af in both regular and fusion mode. per mode, show devin plugins install (the --local wrapper pinned to the full head sha is fine, symlinks aren't) plus the list, and show that deslop, control-cli and control-ui load as pstack skills. post it as a pr comment or in the body and i'll merge on the next sweep.
harness proofreal devin cli on a local box (no cloud agent, no git clone). pr head
1. install / list2. install cache: cmp, symlinks, upstream cmp3. team-kit grep4. skills5. live turns (read-only, describe-only)each mode ran three turns via regular:
|
caelaxie
left a comment
There was a problem hiding this comment.
not merging yet. one proof gap at 45aa2af.
what passes: head unchanged, not a draft, mergeable clean, validate plugin green, body closes #32 through #43. the --local wrapper pins the full head sha, and install + devin plugins list output is pasted. the 203-file cmp shows 0 symlinks, the 3 skills match upstream e73df47, and the team-kit grep finds nothing. 61 /pstack: skills are listed. regular and fusion turns (a) /pstack:deslop and (b) /pstack:poteto-mode paste real answers quoting the cached skill text.
the gap: regular-mode turn (c), bare /deslop. that's the form poteto-mode tells users to type, and it's the only turn with no pasted output. the model answered NO SKILL LOADED. the claim that the cli injected the deslop body rests on prose about the export, not on an excerpt. fusion (c) shows it loading. regular (c) doesn't, so regular mode isn't proven for the bare form.
to clear it, do one of these at the same head:
- paste the regular (c) export excerpt showing the injected deslop body and its 0.15.32 cache source, or
- rerun regular (c) with a prompt that makes the model quote the heading and source, and paste the answer.
no code change needed.
follow-up: regular-mode bare
|
caelaxie
left a comment
There was a problem hiding this comment.
gap from review 5647867681 closed. harness proof verified at 45aa2af in regular and fusion mode.
the follow-up pastes the original regular-mode export. it shows bare /deslop injected the deslop body and listed the pstack 0.15.32 cache source. the swe-2-max rerun pastes a skill invoke deslop call, HEADING: # Remove AI code slop, the 0.15.32 cache path, and exit 0. the heading matches skills/deslop/SKILL.md at head, and the body minus frontmatter is 629 chars there too. the head is unchanged, validate plugin is green, mergeable is clean, and the body closes #32 through #43. this pr passes. squash-merging.
<!-- CURSOR_AGENT_PR_BODY_BEGIN --> synced to [`c742dd6`](cursor/plugins@c742dd6). compared `e73df47..c742dd6` for `pstack/`. that range is the whole upstream pstack history after the previous sync, and `origin/main` of cursor/plugins is that commit. version is `0.15.36` in `plugin.json`, `.devin-plugin/plugin.json`, and the readme marker. upstream range, oldest first: - [`34b1b7c`](cursor/plugins@34b1b7c) ([#977](cursor/plugins#977)) statechart compiler - [`7c7bde7`](cursor/plugins@7c7bde7) ([#978](cursor/plugins#978)) bump to 0.15.33 - [`740d2c0`](cursor/plugins@740d2c0) ([#982](cursor/plugins#982)) qualified action names in property traces - [`164ced1`](cursor/plugins@164ced1) ([#983](cursor/plugins#983)) bump to 0.15.34 - [`519d36a`](cursor/plugins@519d36a) ([#981](cursor/plugins#981)) wait for the reap in the statechart SIGKILL view test - [`ab1f702`](cursor/plugins@ab1f702) ([#986](cursor/plugins#986)) skill updates (poteto-mode, autopilot playbooks, interrogate, arena, ketchup-video, principle-explain-the-number, orchestrate, readme and guide) and bump to 0.15.35 - [`c742dd6`](cursor/plugins@c742dd6) ([#1043](cursor/plugins#1043)) agentic Orchestrate, delete the orch scripts, bump to 0.15.36 `deslop`, `control-cli`, and `control-ui` are byte-identical at `e73df47` and at `c742dd6` (same blobs as devin-pstack #44). not recopied. verbatim, no devin edits: - `skills/statechart/scripts/**` replaced with the compiler, corpus, and tests. old `.mjs` scripts deleted. - `skills/statechart/references/render.md` added. - `skills/poteto-mode/playbooks/autopilot-stack.md` replaced. - `skills/poteto-mode/scripts/package.json` test script drops `orch`. - `skills/poteto-mode/scripts/orch/` deleted (`orch.ts`, `orch.test.ts`, `store.ts`). - `skills/interrogate/references/` deleted (the four review docs the rewrite removed). devin-only changes, per file: - `plugin.json` and `.devin-plugin/plugin.json`: version `0.15.36`. homepage and repository stay on this port. - `README.md`: marker points at `c742dd6` / `0.15.36`. table rows for autopilot-stack, ketchup-video, interrogate, and statechart take the upstream wording with the existing `/pstack:` prefix. - `docs/guide/04-design.md`, `06-verify-and-ship.md`, `07-overnight.md`: upstream wording, `/pstack:` prefix kept, existing Devin session wording kept. - `docs/guide/10-recipes-and-pitfalls.md`: same, plus the `auto` pitfall stays "spawn the role's subagents with `subagent_general` or `subagent_explore`". - `skills/statechart/SKILL.md`: upstream compiler skill. `triggers: [user]`. `/statechart` is `/pstack:statechart`. - `skills/principle-explain-the-number/SKILL.md`: upstream text. `triggers: [user]`. - `skills/create-formal-verification-skill/SKILL.md`: drops "which of those violations a change fixes". `/pstack:statechart` kept. - `skills/ketchup-video/SKILL.md`: subtitled video. `triggers: [user]`. `/pstack:ketchup` and `/pstack:ketchup-video` kept. - `skills/poteto-help/SKILL.md` and `references/recipes.md`: upstream rows and prompts. `/pstack:` prefix, cloud Devin session wording, and the Devin webhook row kept. - `skills/arena/SKILL.md`: new drop-a-seat rule and the skip-the-judge rule, in the existing profile language (`~/.devin/rules/pstack-models.md`, `pstack-M` / `pstack-M-ro`, `subagent_general` / `subagent_explore`, `devin models list`, `swe-2-high`). `auto` on the cross-judge line never judges. On Fusion, prefer a judge outside both the lead's and the sidekick's families, else outside the lead's. a `fusion-*` slug is still a rejected slug. - `skills/interrogate/SKILL.md`: upstream rewrite (findings survive only when a rerun proves them; it calls arena phases). `triggers: [user]`. `generalPurpose` is the write profile arena phase A step 3 maps (`pstack-M`, or `subagent_general` for `auto` / `inherit-parent`). - `skills/setup-pstack/SKILL.md`: the cross-judge sentence is the new one (one judge, other family, list order, alias never judges). Fusion note, `ask_user_question`, and Adaptive wording stay. - `skills/poteto-mode/SKILL.md`: new first-message trigger, Explain the Number applies before you measure, `is_background: true` also covers a steer or resume, and a rejected adjusted slug falls through the calling skill's fallback then `devin models list` / the `auto` mapping. Autopilot-stack is autopilot-full without the merge. Fusion paragraphs stay. - `skills/poteto-mode/playbooks/autonomous-run.md`: mid-run discoveries that support the goal. `ask_user_question` and Devin's `/loop` stay. - `skills/poteto-mode/playbooks/autopilot-full.md`: upstream rebase, verify, blocking, and reply rules. owners stay cloud Devin sessions (`devin --cloud`). `/deslop` and `/pstack:no-comments` stay. control-cli and control-ui stay plain skill names. - `skills/poteto-mode/playbooks/babysit.md`: an Autopilot-stack owner rebases its own branch the same way an Autopilot-full owner does. Origin and GitHub watcher wording stays. - `skills/poteto-mode/playbooks/opening-a-pr.md`: the subagent runs `/deslop` and `/pstack:no-comments` and reports merge-ready. `interrogate` and STACK-READY are gone. - `skills/poteto-mode/playbooks/multi-phase-plan.md`: pick autopilot-full when the run may merge, autopilot-stack when the operator lands the PRs. verdict checklist matches upstream. explores with `profile: "pstack:poteto-agent"`. - `skills/poteto-mode/playbooks/orchestrate.md`: replaced with the short agentic playbook. `Task` is `run_subagent`. workers are cloud Devin sessions (`devin --cloud -p`), leaf-level, because a cloud session cannot spawn `pstack-*` profiles. program state goes in the current agent's store (path in the system prompt), not a project tracker. control-cli and control-ui are named with no plugin qualifier. no orch script calls. skipped: - `pstack/.cursor-plugin/plugin.json`. cursor plugin manifest. the only change in range is the version bump, and this port's manifests are `plugin.json` and `.devin-plugin/plugin.json`. - no `.claude-plugin` file changed in the range. - `docs/harness/claude-code.md` did not change in the range and is not part of this port. tests: - plugin validator: 61 skills, 2 agents, 23 playbooks. - `bash -n` on `skills/poteto-mode/scripts/worktree-audit.sh` and `skills/show-me-your-work/scripts/log.sh`. - `skills/poteto-mode/scripts`: `bun run typecheck` and `bun run test` (watch-pr and check-plan). 61 pass, 0 fail. - `skills/statechart/scripts`: `node --test test/*.test.ts` on Node v22.23.4. 267 pass, 0 fail, 67 skipped. the skips are the plain-TLC differential cases, which the suite itself skips unless `TLA2TOOLS` points at `tla2tools.jar`. corpus replay, the SIGKILL reap test, and the Pele render tests ran. - the `devin` CLI was not run. it needs a login. harness proof for regular mode and fusion mode stays with the owner. <!-- CURSOR_AGENT_PR_BODY_END --> <div><a href="https://cursor.com/agents/bc-f227771c-5753-540a-b70e-a0934a1cb366?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a href="https://cursor.com/background-agent?bcId=bc-f227771c-5753-540a-b70e-a0934a1cb366&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div> Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>
ship deslop, control-cli, and control-ui as ordinary pstack skills, and drop every cursor-team-kit mention.
files copied from cursor/plugins
e73df471cd4bd918367e99f3dd9c51bd53ddf5f0, verbatim (no devin edits; nothing in them blocks loading):skills/deslop/SKILL.mdfromcursor-team-kit/skills/deslop/SKILL.md(blob1b3827c7f991182149a7abda696af43ff8f17a12)skills/control-cli/SKILL.mdfromcursor-team-kit/skills/control-cli/SKILL.md(blob69289ac517e8a28380c8eca5c6692e8a601fa62c)skills/control-ui/SKILL.mdfromcursor-team-kit/skills/control-ui/SKILL.md(blob68484fd5418cc893a6bf40e0db45b3001dcf5947)these three files are identical on cursor/plugins main
99b609a72323b70204eab407c622f436e858e112.cursor-team-kit removals:
README.md: deleted the deslop bullet, the control-cli/control-ui bullet, and the install-alongside linedocs/guide/05-build-and-clean.md: deleted the two sentences that said/deslopships in cursor-team-kitskills/poteto-help/SKILL.md: deleted the not-in-pstack bulletskills/poteto-mode/SKILL.md: droppedfrom the cursor-team-kit plugin; replaced`cursor-team-kit` publisheswithpstack includesskills/poteto-mode/playbooks/autopilot-full.md: droppedfrom the cursor-team-kit pluginandfrom cursor-team-kitskills/poteto-mode/playbooks/multi-phase-plan.md: dropped threefrom cursor-team-kitskills/poteto-mode/playbooks/opening-a-pr.md: droppedfrom cursor-team-kitskills/poteto-mode/playbooks/orchestrate.md: dropped(from cursor-team-kit)skills/poteto-mode/playbooks/shipping.md: droppedfrom cursor-team-kitharness proof (regular + fusion mode) will be posted separately.
Closes #32
Closes #33
Closes #34
Closes #35
Closes #36
Closes #37
Closes #38
Closes #39
Closes #40
Closes #41
Closes #42
Closes #43