Skip to content

[SIGNAL] Refined handling of invalid sigsetsize in syscall_rt_sigaction - #4335

Merged
ptitSeb merged 2 commits into
ptitSeb:mainfrom
ksco:fix-sigaction
Sep 1, 2026
Merged

[SIGNAL] Refined handling of invalid sigsetsize in syscall_rt_sigaction#4335
ptitSeb merged 2 commits into
ptitSeb:mainfrom
ksco:fix-sigaction

Conversation

@ksco

@ksco ksco commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@ptitSeb

ptitSeb commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Why removing the old mechanism for one that is more restrictive? is that the expected behaviour to just refuse the function call if sigsetsize is too small (or too big)? Also, this is expecting sigset_t to be exactly the same size on x64 and native arch (which I assume is not always true, especially on machine that have like 128 signals instead of 64)

@ksco

ksco commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator Author

is that the expected behaviour to just refuse the function call if sigsetsize is too small (or too big)?

Yes, it is how the kernel handles it

@ksco

ksco commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator Author

Also, this is expecting sigset_t to be exactly the same size on x64 and native arch (which I assume is not always true, especially on machine that have like 128 signals instead of 64)

Fair point! Fixed.

@ksco
ksco requested a review from ptitSeb September 1, 2026 08:50
@ptitSeb
ptitSeb merged commit fc1f341 into ptitSeb:main Sep 1, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants