[SIGNAL] Refined handling of invalid sigsetsize in syscall_rt_sigaction - #4335
Merged
Conversation
Owner
|
Why removing the old mechanism for one that is more restrictive? is that the expected behaviour to just refuse the function call if sigsetsize is too small (or too big)? Also, this is expecting sigset_t to be exactly the same size on x64 and native arch (which I assume is not always true, especially on machine that have like 128 signals instead of 64) |
Collaborator
Author
Yes, it is how the kernel handles it |
Collaborator
Author
Fair point! Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.