test: ignore the SigV4 signature in two-run stdout tests - #25
Open
noahpotti wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestQuietSilencesStderrandTestStatusNeverLeaksToStdoutare flaky (geiger-sne). Both fail on main now.Each test compares the stdout of two runs. AWS SigV4 signs with the wall clock (
internal/sign/sigv4.go). When the two runs cross a second boundary, theX-Amz-Datevalue and the signature change. The comparison then fails.The subject of both tests is the effect of a flag on stdout. The signature is not the subject. Both tests now remove the
AuthorizationandX-Amz-Datevalues before the comparison.TestWithoutSigningMaterialHidesOnlyTheSignatureholds that helper to its limits. A different signature is not a difference. A different URL or a different command is a difference.To make sure that the tests still catch a real fault, I made
captureRunwrite an extra line to stdout.TestStatusNeverLeaksToStdoutfailed, as it must. I then ran all three tests 60 times with no failure.This commit was part of #24, but the merge did not include it.
Gate: gofmt, vet,
-race -shuffle=on, golangci-lint.